Merge branch '4.3' into 4.4

* 4.3:
  Fix tests
  [Console] Fix commands description with numeric namespaces
  [HttpFoundation] Fixed typo
  [EventDispatcher] Better error reporting when arguments to dispatch() are swapped
  [Serializer] CsvEncoder::NO_HEADERS_KEY ignored when used in constructor
  [Form] Keep preferred_choices order for choice groups
  [Debug] work around failing chdir() on Darwin
  [PhpUnitBridge] Read configuration CLI directive
  [DI] Missing test on YamlFileLoader
  Revert "minor #34608 [Process] add tests for php executable finder if file does not exist (ahmedash95)"
  Simpler example for Apache basic auth workaround
  [Console] Fix trying to access array offset on value of type int
  [Config] Remove extra sprintf arg
  [VarDumper] notice on potential undefined index
  [HttpClient] turn exception into log when the request has no content-type
  [Process] add tests for php executable finder if file does not exist
  [Cache] Make sure we get the correct number of values from redis::mget()
  [TwigBridge] Add row_attr to all form themes
  [Serializer] Fix MetadataAwareNameConverter usage with string group

Author: nicolas-grekas

ChoiceList/Factory/DefaultChoiceListFactory.php

@@ -105,6 +105,14 @@ public function createView(ChoiceListInterface $list, $preferredChoices = null,
                     unset($otherViews[$key]);
                 }
             }
+
+            foreach ($preferredViewsOrder as $key => $groupViewsOrder) {
+                if ($groupViewsOrder) {
+                    $preferredViewsOrder[$key] = min($groupViewsOrder);
+                } else {
+                    unset($preferredViewsOrder[$key]);
+                }
+            }
         } else {
             // Otherwise use the original structure of the choices
             self::addChoiceViewsFromStructuredValues(
@@ -249,6 +257,9 @@ private static function addChoiceViewsGroupedByCallable(callable $groupBy, $choi
                 $preferredViews[$groupLabel] = new ChoiceGroupView($groupLabel);
                 $otherViews[$groupLabel] = new ChoiceGroupView($groupLabel);
             }
+            if (!isset($preferredViewsOrder[$groupLabel])) {
+                $preferredViewsOrder[$groupLabel] = [];
+            }
 
             self::addChoiceView(
                 $choice,
@@ -259,7 +270,7 @@ private static function addChoiceViewsGroupedByCallable(callable $groupBy, $choi
                 $attr,
                 $isPreferred,
                 $preferredViews[$groupLabel]->choices,
-                $preferredViewsOrder,
+                $preferredViewsOrder[$groupLabel],
                 $otherViews[$groupLabel]->choices
             );
         }

Tests/ChoiceList/Factory/DefaultChoiceListFactoryTest.php

@@ -256,6 +256,37 @@ public function testCreateViewFlatPreferredChoicesSameOrder()
         );
     }
 
+    public function testCreateViewFlatPreferredChoiceGroupsSameOrder()
+    {
+        $view = $this->factory->createView(
+            $this->list,
+            [$this->obj4, $this->obj2, $this->obj1, $this->obj3],
+            null, // label
+            null, // index
+            [$this, 'getGroup']
+        );
+
+        $preferredLabels = array_map(static function (ChoiceGroupView $groupView): array {
+            return array_map(static function (ChoiceView $view): string {
+                return $view->label;
+            }, $groupView->choices);
+        }, $view->preferredChoices);
+
+        $this->assertEquals(
+            [
+                'Group 2' => [
+                    2 => 'C',
+                    3 => 'D',
+                ],
+                'Group 1' => [
+                    0 => 'A',
+                    1 => 'B',
+                ],
+            ],
+            $preferredLabels
+        );
+    }
+
     public function testCreateViewFlatPreferredChoicesEmptyArray()
     {
         $view = $this->factory->createView(