Merge branch '5.4' into 6.0

* 5.4: (27 commits)
  feat: add completion for DebugAutowiring search argument
  [Routing] Add support for aliasing routes
  [DependencyInjection] only allow `ReflectionNamedType` for `ServiceSubscriberTrait`
  Fix CS
  [Console] Open CompleteCommand for custom outputs
  [Intl] Update the ICU data to 70.1
  [Messenger] Add completion for failed messages commands.
  Fix tests
  Fixing missing full_stack variable that's needed by toolbar.html.twig
  [PropertyInfo] Bump phpstan/phpdoc-parser
  [Security] Backport type fixes
  [VarExporter] escape unicode chars involved in directionality
  [Framework] Add completion to debug:container
  [Messenger] Add completion to command messenger:consume
  [Intl] Update the ICU data to 70.1
  Fix more generic types
  Default access_decision_manager.strategy option with merge.
  Fix typos
  Update validators.ca.xlf
  Add missing Validator translations for Estonian
  ...

Signed-off-by: Alexander M. Turek <[email protected]>

Author: derrabus

Extension/Validator/ViolationMapper/ViolationMapper.php

@@ -57,7 +57,7 @@ public function mapViolation(ConstraintViolation $violation, FormInterface $form
         $match = false;
 
         // Don't create a ViolationPath instance for empty property paths
-        if (\strlen($violation->getPropertyPath()) > 0) {
+        if ('' !== $violation->getPropertyPath()) {
             $violationPath = new ViolationPath($violation->getPropertyPath());
             $relativePath = $this->reconstructPath($violationPath, $form);
         }

Extension/Validator/ViolationMapper/ViolationPath.php

@@ -17,10 +17,12 @@
 
 /**
  * @author Bernhard Schussek <[email protected]>
+ *
+ * @implements \IteratorAggregate<int, string>
  */
 class ViolationPath implements \IteratorAggregate, PropertyPathInterface
 {
-    /** @var string[] */
+    /** @var list<string> */
     private array $elements = [];
     private array $isIndex = [];
     private array $mapsForm = [];

FormBuilderInterface.php

@@ -14,7 +14,7 @@
 /**
  * @author Bernhard Schussek <[email protected]>
  *
- * @extends \Traversable<string, self>
+ * @extends \Traversable<string, FormBuilderInterface>
  */
 interface FormBuilderInterface extends \Traversable, \Countable, FormConfigBuilderInterface
 {

FormErrorIterator.php

@@ -44,7 +44,7 @@ class FormErrorIterator implements \RecursiveIterator, \SeekableIterator, \Array
     private array $errors;
 
     /**
-     * @param array<int, FormError|self> $errors
+     * @param list<FormError|self> $errors
      *
      * @throws InvalidArgumentException If the errors are invalid
      */

Util/OrderedHashMap.php

@@ -81,11 +81,15 @@ class OrderedHashMap implements \ArrayAccess, \IteratorAggregate, \Countable
 
     /**
      * The keys of the map in the order in which they were inserted or changed.
+     *
+     * @var list<TKey>
      */
     private array $orderedKeys = [];
 
     /**
      * References to the cursors of all open iterators.
+     *
+     * @var array<int, int>
      */
     private array $managedCursors = [];
 

Util/OrderedHashMapIterator.php

@@ -18,27 +18,32 @@
  *
  * @internal
  *
- * @template TKey
- * @template TValue
+ * @template-covariant TKey of array-key
+ * @template-covariant TValue
  *
  * @implements \Iterator<TKey, TValue>
  */
 class OrderedHashMapIterator implements \Iterator
 {
+    /** @var array<TKey, TValue> */
     private array $elements;
+    /** @var list<TKey> */
     private array $orderedKeys;
     private int $cursor = 0;
     private int $cursorId;
+    /** @var array<int, int> */
     private array $managedCursors;
+    /** @var TKey|null */
     private string|int|null $key = null;
+    /** @var TValue|null */
     private mixed $current = null;
 
     /**
      * @param array<TKey, TValue> $elements       The elements of the map, indexed by their
      *                                            keys
-     * @param array               $orderedKeys    The keys of the map in the order in which
+     * @param list<TKey>          $orderedKeys    The keys of the map in the order in which
      *                                            they should be iterated
-     * @param array               $managedCursors An array from which to reference the
+     * @param array<int, int>     $managedCursors An array from which to reference the
      *                                            iterator's cursor as long as it is alive.
      *                                            This array is managed by the corresponding
      *                                            {@link OrderedHashMap} instance to support