Move array_merge calls out of loops to improve performance

Author: simonberger

Extension/Validator/ViolationMapper/ViolationMapper.php

@@ -185,13 +185,18 @@ public function mapViolation(ConstraintViolation $violation, FormInterface $form
 
                     if (null !== $this->translator) {
                         $form = $scope;
-                        $translationParameters = $form->getConfig()->getOption('label_translation_parameters', []);
+                        $translationParameters[] = $form->getConfig()->getOption('label_translation_parameters', []);
 
                         do {
                             $translationDomain = $form->getConfig()->getOption('translation_domain');
-                            $translationParameters = array_merge($form->getConfig()->getOption('label_translation_parameters', []), $translationParameters);
+                            array_unshift(
+                                $translationParameters,
+                                $form->getConfig()->getOption('label_translation_parameters', [])
+                            );
                         } while (null === $translationDomain && null !== $form = $form->getParent());
 
+                        $translationParameters = array_merge([], ...$translationParameters);
+
                         $label = $this->translator->trans(
                             $label,
                             $translationParameters,

FormRegistry.php

@@ -100,7 +100,6 @@ public function getType(string $name)
      */
     private function resolveType(FormTypeInterface $type): ResolvedFormTypeInterface
     {
-        $typeExtensions = [];
         $parentType = $type->getParent();
         $fqcn = \get_class($type);
 
@@ -111,17 +110,15 @@ private function resolveType(FormTypeInterface $type): ResolvedFormTypeInterface
 
         $this->checkedTypes[$fqcn] = true;
 
+        $typeExtensions = [];
         try {
             foreach ($this->extensions as $extension) {
-                $typeExtensions = array_merge(
-                    $typeExtensions,
-                    $extension->getTypeExtensions($fqcn)
-                );
+                $typeExtensions[] = $extension->getTypeExtensions($fqcn);
             }
 
             return $this->resolvedTypeFactory->createResolvedType(
                 $type,
-                $typeExtensions,
+                array_merge([], ...$typeExtensions),
                 $parentType ? $this->getType($parentType) : null
             );
         } finally {

FormTypeGuesserChain.php

@@ -25,17 +25,20 @@ class FormTypeGuesserChain implements FormTypeGuesserInterface
      */
     public function __construct(iterable $guessers)
     {
+        $tmpGuessers = [];
         foreach ($guessers as $guesser) {
             if (!$guesser instanceof FormTypeGuesserInterface) {
                 throw new UnexpectedTypeException($guesser, FormTypeGuesserInterface::class);
             }
 
             if ($guesser instanceof self) {
-                $this->guessers = array_merge($this->guessers, $guesser->guessers);
+                $tmpGuessers[] = $guesser->guessers;
             } else {
-                $this->guessers[] = $guesser;
+                $tmpGuessers[] = [$guesser];
             }
         }
+
+        $this->guessers = array_merge([], ...$tmpGuessers);
     }
 
     /**