Use ??= more

Author: nicolas-grekas

ChoiceList/Factory/DefaultChoiceListFactory.php

@@ -74,9 +74,7 @@ public function createView(ChoiceListInterface $list, array|callable $preferredC
         }
 
         // The names are generated from an incrementing integer by default
-        if (null === $index) {
-            $index = 0;
-        }
+        $index ??= 0;
 
         // If $groupBy is a callable returning a string
         // choices are added to the group with the name returned by the callable.

Console/Descriptor/TextDescriptor.php

@@ -194,9 +194,7 @@ private function normalizeAndSortOptionsColumns(array $options): array
 
     private function formatClassLink(string $class, string $text = null): string
     {
-        if (null === $text) {
-            $text = $class;
-        }
+        $text ??= $class;
 
         if ('' === $fileLink = $this->getFileLink($class)) {
             return $text;

Extension/Core/DataMapper/CheckboxListMapper.php

@@ -27,11 +27,7 @@ class CheckboxListMapper implements DataMapperInterface
 {
     public function mapDataToForms(mixed $choices, \Traversable $checkboxes)
     {
-        if (null === $choices) {
-            $choices = [];
-        }
-
-        if (!\is_array($choices)) {
+        if (!\is_array($choices ??= [])) {
             throw new UnexpectedTypeException($choices, 'array');
         }
 

Extension/Core/DataTransformer/ArrayToPartsTransformer.php

@@ -30,11 +30,7 @@ public function __construct(array $partMapping)
 
     public function transform(mixed $array): mixed
     {
-        if (null === $array) {
-            $array = [];
-        }
-
-        if (!\is_array($array)) {
+        if (!\is_array($array ??= [])) {
             throw new TransformationFailedException('Expected an array.');
         }
 

Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformer.php

@@ -45,13 +45,8 @@ public function __construct(string $inputTimezone = null, string $outputTimezone
     {
         parent::__construct($inputTimezone, $outputTimezone);
 
-        if (null === $dateFormat) {
-            $dateFormat = \IntlDateFormatter::MEDIUM;
-        }
-
-        if (null === $timeFormat) {
-            $timeFormat = \IntlDateFormatter::SHORT;
-        }
+        $dateFormat ??= \IntlDateFormatter::MEDIUM;
+        $timeFormat ??= \IntlDateFormatter::SHORT;
 
         if (!\in_array($dateFormat, self::$formats, true)) {
             throw new UnexpectedTypeException($dateFormat, implode('", "', self::$formats));

Extension/Core/DataTransformer/PercentToLocalizedStringTransformer.php

@@ -48,9 +48,7 @@ class PercentToLocalizedStringTransformer implements DataTransformerInterface
      */
     public function __construct(int $scale = null, string $type = null, int $roundingMode = \NumberFormatter::ROUND_HALFUP, bool $html5Format = false)
     {
-        if (null === $type) {
-            $type = self::FRACTIONAL;
-        }
+        $type ??= self::FRACTIONAL;
 
         if (!\in_array($type, self::$types, true)) {
             throw new UnexpectedTypeException($type, implode('", "', self::$types));

Extension/Core/EventListener/MergeCollectionListener.php

@@ -44,11 +44,7 @@ public static function getSubscribedEvents(): array
     public function onSubmit(FormEvent $event)
     {
         $dataToMergeInto = $event->getForm()->getNormData();
-        $data = $event->getData();
-
-        if (null === $data) {
-            $data = [];
-        }
+        $data = $event->getData() ?? [];
 
         if (!\is_array($data) && !($data instanceof \Traversable && $data instanceof \ArrayAccess)) {
             throw new UnexpectedTypeException($data, 'array or (\Traversable and \ArrayAccess)');

Extension/Core/EventListener/ResizeFormListener.php

@@ -53,11 +53,7 @@ public static function getSubscribedEvents(): array
     public function preSetData(FormEvent $event)
     {
         $form = $event->getForm();
-        $data = $event->getData();
-
-        if (null === $data) {
-            $data = [];
-        }
+        $data = $event->getData() ?? [];
 
         if (!\is_array($data) && !($data instanceof \Traversable && $data instanceof \ArrayAccess)) {
             throw new UnexpectedTypeException($data, 'array or (\Traversable and \ArrayAccess)');
@@ -109,16 +105,12 @@ public function preSubmit(FormEvent $event)
     public function onSubmit(FormEvent $event)
     {
         $form = $event->getForm();
-        $data = $event->getData();
+        $data = $event->getData() ?? [];
 
         // At this point, $data is an array or an array-like object that already contains the
         // new entries, which were added by the data mapper. The data mapper ignores existing
         // entries, so we need to manually unset removed entries in the collection.
 
-        if (null === $data) {
-            $data = [];
-        }
-
         if (!\is_array($data) && !($data instanceof \Traversable && $data instanceof \ArrayAccess)) {
             throw new UnexpectedTypeException($data, 'array or (\Traversable and \ArrayAccess)');
         }

Extension/Core/Type/BaseType.php

@@ -54,9 +54,7 @@ public function buildView(FormView $view, FormInterface $form, array $options)
                 $uniqueBlockPrefix = '_'.$blockName;
             }
 
-            if (null === $translationDomain) {
-                $translationDomain = $view->parent->vars['translation_domain'];
-            }
+            $translationDomain ??= $view->parent->vars['translation_domain'];
 
             $labelTranslationParameters = array_merge($view->parent->vars['label_translation_parameters'], $labelTranslationParameters);
             $attrTranslationParameters = array_merge($view->parent->vars['attr_translation_parameters'], $attrTranslationParameters);

Extension/Validator/ViolationMapper/ViolationMapper.php

@@ -176,8 +176,8 @@ public function mapViolation(ConstraintViolation $violation, FormInterface $form
                 if (false !== $label) {
                     if (null === $label && null !== $this->formRenderer) {
                         $label = $this->formRenderer->humanize($scope->getName());
-                    } elseif (null === $label) {
-                        $label = $scope->getName();
+                    } else {
+                        $label ??= $scope->getName();
                     }
 
                     if (null !== $this->translator) {