Replace more docblocks by type-hints

Author: nicolas-grekas

ButtonBuilder.php

@@ -53,17 +53,11 @@ class ButtonBuilder implements \IteratorAggregate, FormBuilderInterface
     private $options;
 
     /**
-     * Creates a new button builder.
-     *
-     * @param string $name    The name of the button
-     * @param array  $options The button's options
-     *
      * @throws InvalidArgumentException if the name is empty
      */
-    public function __construct($name, array $options = array())
+    public function __construct(?string $name, array $options = array())
     {
-        $name = (string) $name;
-        if ('' === $name) {
+        if ('' === $name || null === $name) {
             throw new InvalidArgumentException('Buttons cannot have empty names.');
         }
 

ChoiceList/ArrayChoiceList.php

@@ -62,7 +62,7 @@ class ArrayChoiceList implements ChoiceListInterface
      *                                    incrementing integers are used as
      *                                    values
      */
-    public function __construct($choices, callable $value = null)
+    public function __construct(iterable $choices, callable $value = null)
     {
         if ($choices instanceof \Traversable) {
             $choices = iterator_to_array($choices);

ChoiceList/View/ChoiceView.php

@@ -35,7 +35,7 @@ class ChoiceView
      * @param string $label The label displayed to humans
      * @param array  $attr  Additional attributes for the HTML tag
      */
-    public function __construct($data, $value, $label, array $attr = array())
+    public function __construct($data, string $value, $label, array $attr = array())
     {
         $this->data = $data;
         $this->value = $value;

DependencyInjection/FormPass.php

@@ -36,7 +36,7 @@ class FormPass implements CompilerPassInterface
     private $formTypeGuesserTag;
     private $formDebugCommandService;
 
-    public function __construct($formExtensionService = 'form.extension', $formTypeTag = 'form.type', $formTypeExtensionTag = 'form.type_extension', $formTypeGuesserTag = 'form.type_guesser', $formDebugCommandService = DebugCommand::class)
+    public function __construct(string $formExtensionService = 'form.extension', string $formTypeTag = 'form.type', string $formTypeExtensionTag = 'form.type_extension', string $formTypeGuesserTag = 'form.type_guesser', string $formDebugCommandService = DebugCommand::class)
     {
         $this->formExtensionService = $formExtensionService;
         $this->formTypeTag = $formTypeTag;

Exception/UnexpectedTypeException.php

@@ -13,7 +13,7 @@
 
 class UnexpectedTypeException extends InvalidArgumentException
 {
-    public function __construct($value, $expectedType)
+    public function __construct($value, string $expectedType)
     {
         parent::__construct(sprintf('Expected argument of type "%s", "%s" given', $expectedType, is_object($value) ? get_class($value) : gettype($value)));
     }

Extension/Core/DataTransformer/BaseDateTimeTransformer.php

@@ -36,7 +36,7 @@ abstract class BaseDateTimeTransformer implements DataTransformerInterface
      * @throws UnexpectedTypeException  if a timezone is not a string
      * @throws InvalidArgumentException if a timezone is not valid
      */
-    public function __construct($inputTimezone = null, $outputTimezone = null)
+    public function __construct(string $inputTimezone = null, string $outputTimezone = null)
     {
         if (null !== $inputTimezone && !is_string($inputTimezone)) {
             throw new UnexpectedTypeException($inputTimezone, 'string');

Extension/Core/DataTransformer/BooleanToStringTransformer.php

@@ -27,7 +27,7 @@ class BooleanToStringTransformer implements DataTransformerInterface
     /**
      * @param string $trueValue The value emitted upon transform if the input is true
      */
-    public function __construct($trueValue)
+    public function __construct(string $trueValue)
     {
         $this->trueValue = $trueValue;
     }

Extension/Core/DataTransformer/DateIntervalToArrayTransformer.php

@@ -46,13 +46,13 @@ class DateIntervalToArrayTransformer implements DataTransformerInterface
      * @param string[] $fields The date fields
      * @param bool     $pad    Whether to use padding
      */
-    public function __construct(array $fields = null, $pad = false)
+    public function __construct(array $fields = null, bool $pad = false)
     {
         if (null === $fields) {
             $fields = array('years', 'months', 'days', 'hours', 'minutes', 'seconds', 'invert');
         }
         $this->fields = $fields;
-        $this->pad = (bool) $pad;
+        $this->pad = $pad;
     }
 
     /**

Extension/Core/DataTransformer/DateIntervalToStringTransformer.php

@@ -33,7 +33,7 @@ class DateIntervalToStringTransformer implements DataTransformerInterface
      * @param string $format      The date format
      * @param bool   $parseSigned Whether to parse as a signed interval
      */
-    public function __construct($format = 'P%yY%mM%dDT%hH%iM%sS', $parseSigned = false)
+    public function __construct(string $format = 'P%yY%mM%dDT%hH%iM%sS', bool $parseSigned = false)
     {
         $this->format = $format;
         $this->parseSigned = $parseSigned;

Extension/Core/DataTransformer/DateTimeToArrayTransformer.php

@@ -34,7 +34,7 @@ class DateTimeToArrayTransformer extends BaseDateTimeTransformer
      *
      * @throws UnexpectedTypeException if a timezone is not a string
      */
-    public function __construct($inputTimezone = null, $outputTimezone = null, array $fields = null, $pad = false)
+    public function __construct(string $inputTimezone = null, string $outputTimezone = null, array $fields = null, bool $pad = false)
     {
         parent::__construct($inputTimezone, $outputTimezone);
 
@@ -43,7 +43,7 @@ public function __construct($inputTimezone = null, $outputTimezone = null, array
         }
 
         $this->fields = $fields;
-        $this->pad = (bool) $pad;
+        $this->pad = $pad;
     }
 
     /**