[Form] Removed legacy check in ValidationListener

HeahDude · HeahDude · commit 3c8cd70ebc73 · 2020-04-11T22:17:48.000+02:00
diff --git a/Extension/Validator/EventListener/ValidationListener.php b/Extension/Validator/EventListener/ValidationListener.php
@@ -55,8 +55,7 @@ public function validateForm(FormEvent $event)
             foreach ($this->validator->validate($form) as $violation) {
                 // Allow the "invalid" constraint to be put onto
                 // non-synchronized forms
-                // ConstraintViolation::getConstraint() must not expect to provide a constraint as long as Symfony\Component\Validator\ExecutionContext exists (before 3.0)
-                $allowNonSynchronized = (null === $violation->getConstraint() || $violation->getConstraint() instanceof Form) && Form::NOT_SYNCHRONIZED_ERROR === $violation->getCode();
+                $allowNonSynchronized = $violation->getConstraint() instanceof Form && Form::NOT_SYNCHRONIZED_ERROR === $violation->getCode();
 
                 $this->violationMapper->mapViolation($violation, $form, $allowNonSynchronized);
             }

Original file line number	Diff line number	Diff line change
`@@ -55,8 +55,7 @@ public function validateForm(FormEvent $event)`
`55`	`55`	`foreach ($this->validator->validate($form) as $violation) {`
`56`	`56`	`// Allow the "invalid" constraint to be put onto`
`57`	`57`	`// non-synchronized forms`
`58`		`- // ConstraintViolation::getConstraint() must not expect to provide a constraint as long as Symfony\Component\Validator\ExecutionContext exists (before 3.0)`
`59`		`- $allowNonSynchronized = (null === $violation->getConstraint() \|\| $violation->getConstraint() instanceof Form) && Form::NOT_SYNCHRONIZED_ERROR === $violation->getCode();`
	`58`	`+ $allowNonSynchronized = $violation->getConstraint() instanceof Form && Form::NOT_SYNCHRONIZED_ERROR === $violation->getCode();`
`60`	`59`
`61`	`60`	`$this->violationMapper->mapViolation($violation, $form, $allowNonSynchronized);`
`62`	`61`	`}`