Merge branch '3.4'

* 3.4:
  [HttpFoundation] refactoring: calculate when need
  [Serializer] Fix extra attributes when no group specified
  [Intl] Make intl-data tests pass and save language aliases again
  [FrameworkBundle][Config] fix: do not add resource checkers for debug=false
  [DI] Fix "almost-circular" dependencies handling
  [Console] Fix CommandTester::setInputs() docblock
  Only enabling validation if it is present
  Fix displaying errors for bootstrap 4
  [Serializer] readd default argument value
  Fix reference dump for deprecated nodes
  [PhpUnitBridge] Fixed fatal error in CoverageListener when something goes wrong in Test::setUpBeforeClass
  [HttpKernel] Let the storage manage the session starts
  [VarDumper] fix trailling comma when dumping an exception
  [Validator] Fix TraceableValidator is reset on data collector instantiation
  Remove useless docblocks
  [FrameworkBundle] Fix docblocks
  [PropertyInfo] Remove useless docblocks

Author: nicolas-grekas

AbstractRendererEngine.php

@@ -127,13 +127,13 @@ abstract protected function loadResourceForBlockName($cacheKey, FormView $view,
      *
      * @see getResourceForBlockHierarchy()
      *
-     * @param string   $cacheKey           the cache key used for storing the
+     * @param string   $cacheKey           The cache key used for storing the
      *                                     resource
-     * @param FormView $view               the form view for finding the applying
+     * @param FormView $view               The form view for finding the applying
      *                                     themes
-     * @param array    $blockNameHierarchy the block hierarchy, with the most
+     * @param array    $blockNameHierarchy The block hierarchy, with the most
      *                                     specific block name at the end
-     * @param int      $hierarchyLevel     the level in the block hierarchy that
+     * @param int      $hierarchyLevel     The level in the block hierarchy that
      *                                     should be loaded
      *
      * @return bool True if the resource could be loaded, false otherwise

CallbackTransformer.php

@@ -16,18 +16,7 @@
 
 class CallbackTransformer implements DataTransformerInterface
 {
-    /**
-     * The callback used for forward transform.
-     *
-     * @var callable
-     */
     private $transform;
-
-    /**
-     * The callback used for reverse transform.
-     *
-     * @var callable
-     */
     private $reverseTransform;
 
     /**

ChoiceList/LazyChoiceList.php

@@ -27,11 +27,6 @@
  */
 class LazyChoiceList implements ChoiceListInterface
 {
-    /**
-     * The choice loader.
-     *
-     * @var ChoiceLoaderInterface
-     */
     private $loader;
 
     /**
@@ -51,8 +46,7 @@ class LazyChoiceList implements ChoiceListInterface
      * argument.
      *
      * @param ChoiceLoaderInterface $loader The choice loader
-     * @param null|callable         $value  The callable generating the choice
-     *                                      values
+     * @param null|callable         $value  The callable generating the choice values
      */
     public function __construct(ChoiceLoaderInterface $loader, callable $value = null)
     {

ChoiceList/View/ChoiceGroupView.php

@@ -18,26 +18,14 @@
  */
 class ChoiceGroupView implements \IteratorAggregate
 {
-    /**
-     * The label of the group.
-     *
-     * @var string
-     */
     public $label;
-
-    /**
-     * The choice views in the group.
-     *
-     * @var ChoiceGroupView[]|ChoiceView[]
-     */
     public $choices;
 
     /**
      * Creates a new choice group view.
      *
      * @param string                         $label   The label of the group
-     * @param ChoiceGroupView[]|ChoiceView[] $choices the choice views in the
-     *                                                group
+     * @param ChoiceGroupView[]|ChoiceView[] $choices the choice views in the group
      */
     public function __construct($label, array $choices = array())
     {

ChoiceList/View/ChoiceListView.php

@@ -22,26 +22,14 @@
  */
 class ChoiceListView
 {
-    /**
-     * The choices.
-     *
-     * @var ChoiceGroupView[]|ChoiceView[]
-     */
     public $choices;
-
-    /**
-     * The preferred choices.
-     *
-     * @var ChoiceGroupView[]|ChoiceView[]
-     */
     public $preferredChoices;
 
     /**
      * Creates a new choice list view.
      *
      * @param ChoiceGroupView[]|ChoiceView[] $choices          The choice views
-     * @param ChoiceGroupView[]|ChoiceView[] $preferredChoices the preferred
-     *                                                         choice views
+     * @param ChoiceGroupView[]|ChoiceView[] $preferredChoices the preferred choice views
      */
     public function __construct(array $choices = array(), array $preferredChoices = array())
     {

ChoiceList/View/ChoiceView.php

@@ -18,25 +18,8 @@
  */
 class ChoiceView
 {
-    /**
-     * The label displayed to humans.
-     *
-     * @var string
-     */
     public $label;
-
-    /**
-     * The view representation of the choice.
-     *
-     * @var string
-     */
     public $value;
-
-    /**
-     * The original choice value.
-     *
-     * @var mixed
-     */
     public $data;
 
     /**

Extension/Core/CoreExtension.php

@@ -26,14 +26,7 @@
  */
 class CoreExtension extends AbstractExtension
 {
-    /**
-     * @var PropertyAccessorInterface
-     */
     private $propertyAccessor;
-
-    /**
-     * @var ChoiceListFactoryInterface
-     */
     private $choiceListFactory;
 
     public function __construct(PropertyAccessorInterface $propertyAccessor = null, ChoiceListFactoryInterface $choiceListFactory = null)

Extension/Core/DataTransformer/BooleanToStringTransformer.php

@@ -22,17 +22,10 @@
  */
 class BooleanToStringTransformer implements DataTransformerInterface
 {
-    /**
-     * The value emitted upon transform if the input is true.
-     *
-     * @var string
-     */
     private $trueValue;
 
     /**
-     * Sets the value emitted upon transform if the input is true.
-     *
-     * @param string $trueValue
+     * @param string $trueValue The value emitted upon transform if the input is true
      */
     public function __construct($trueValue)
     {

Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformer.php

@@ -149,7 +149,7 @@ public function reverseTransform($value)
     /**
      * Returns a preconfigured IntlDateFormatter instance.
      *
-     * @param bool $ignoreTimezone use UTC regardless of the configured timezone
+     * @param bool $ignoreTimezone Use UTC regardless of the configured timezone
      *
      * @return \IntlDateFormatter
      *

Extension/Core/DataTransformer/PercentToLocalizedStringTransformer.php

@@ -32,7 +32,6 @@ class PercentToLocalizedStringTransformer implements DataTransformerInterface
     );
 
     private $type;
-
     private $scale;
 
     /**