Add missing return types to tests/internal/final methods

Author: nicolas-grekas

ChoiceList/Factory/Cache/ChoiceLoader.php

@@ -11,6 +11,7 @@
 
 namespace Symfony\Component\Form\ChoiceList\Factory\Cache;
 
+use Symfony\Component\Form\ChoiceList\ChoiceListInterface;
 use Symfony\Component\Form\ChoiceList\Loader\ChoiceLoaderInterface;
 use Symfony\Component\Form\FormTypeExtensionInterface;
 use Symfony\Component\Form\FormTypeInterface;
@@ -28,23 +29,23 @@ final class ChoiceLoader extends AbstractStaticOption implements ChoiceLoaderInt
     /**
      * {@inheritdoc}
      */
-    public function loadChoiceList(callable $value = null)
+    public function loadChoiceList(callable $value = null): ChoiceListInterface
     {
         return $this->getOption()->loadChoiceList($value);
     }
 
     /**
      * {@inheritdoc}
      */
-    public function loadChoicesForValues(array $values, callable $value = null)
+    public function loadChoicesForValues(array $values, callable $value = null): array
     {
         return $this->getOption()->loadChoicesForValues($values, $value);
     }
 
     /**
      * {@inheritdoc}
      */
-    public function loadValuesForChoices(array $choices, callable $value = null)
+    public function loadValuesForChoices(array $choices, callable $value = null): array
     {
         return $this->getOption()->loadValuesForChoices($choices, $value);
     }

ChoiceList/Loader/AbstractChoiceLoader.php

@@ -12,6 +12,7 @@
 namespace Symfony\Component\Form\ChoiceList\Loader;
 
 use Symfony\Component\Form\ChoiceList\ArrayChoiceList;
+use Symfony\Component\Form\ChoiceList\ChoiceListInterface;
 
 /**
  * @author Jules Pietri <[email protected]>
@@ -30,7 +31,7 @@ abstract class AbstractChoiceLoader implements ChoiceLoaderInterface
      *
      * {@inheritdoc}
      */
-    public function loadChoiceList(callable $value = null)
+    public function loadChoiceList(callable $value = null): ChoiceListInterface
     {
         return $this->choiceList ?? ($this->choiceList = new ArrayChoiceList($this->loadChoices(), $value));
     }

Tests/Fixtures/ChoiceList/DeprecatedChoiceListFactory.php

@@ -5,18 +5,19 @@
 use Symfony\Component\Form\ChoiceList\ChoiceListInterface;
 use Symfony\Component\Form\ChoiceList\Factory\ChoiceListFactoryInterface;
 use Symfony\Component\Form\ChoiceList\Loader\ChoiceLoaderInterface;
+use Symfony\Component\Form\ChoiceList\View\ChoiceListView;
 
 class DeprecatedChoiceListFactory implements ChoiceListFactoryInterface
 {
-    public function createListFromChoices(iterable $choices, callable $value = null)
+    public function createListFromChoices(iterable $choices, callable $value = null): ChoiceListInterface
     {
     }
 
-    public function createListFromLoader(ChoiceLoaderInterface $loader, callable $value = null)
+    public function createListFromLoader(ChoiceLoaderInterface $loader, callable $value = null): ChoiceListInterface
     {
     }
 
-    public function createView(ChoiceListInterface $list, $preferredChoices = null, $label = null, callable $index = null, callable $groupBy = null, $attr = null)
+    public function createView(ChoiceListInterface $list, $preferredChoices = null, $label = null, callable $index = null, callable $groupBy = null, $attr = null): ChoiceListView
     {
     }
 }