Skip to content

Commit 4d57f2a

Browse files
minor #61372 chore: PHP CS Fixer - update heredoc handling (keradus)
This PR was merged into the 7.4 branch. Discussion ---------- chore: PHP CS Fixer - update heredoc handling | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Issues | Fix CS <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT Inspired while #61371 , but can be merged separately. ``@PHPxMigration`` and ``@Symfony`` ruleset have different config for those rules. I assume the difference is coming from supporting pre-7.2 PHP version earlier in the codebase, where heredoc closure and trailing comma had to be on separated lines - but it's no longer the case. Can we benefit from newer PHP syntax and incorporate those changes? (yes, `trailing_comma_in_multiline`, part of ``@Symfony``, is already having this enabled!) if so, i will also merge them into ``@Symfony`` ruleset itself afterwards. with love by [PHP Coding Standards Fixer](https://cs.symfony.com/) Commits ------- f9956227bb6 chore: PHP CS Fixer - update heredoc handling
2 parents 9c67a3b + 2972625 commit 4d57f2a

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

Tests/Command/DebugCommandTest.php

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,9 @@ public function testDebugDeprecatedDefaults()
5252
* Symfony\Component\Form\Tests\Command\FooType
5353
5454
55-
TXT
56-
, $tester->getDisplay(true));
55+
TXT,
56+
$tester->getDisplay(true)
57+
);
5758
}
5859

5960
public function testDebugSingleFormType()
@@ -134,8 +135,9 @@ public function testDebugAmbiguousFormTypeInteractive()
134135
%A
135136
%A\A\AmbiguousType (Block prefix: "ambiguous")
136137
%A
137-
TXT
138-
, $output);
138+
TXT,
139+
$output
140+
);
139141
}
140142

141143
public function testDebugInvalidFormType()
@@ -183,8 +185,9 @@ class:%s
183185
Nested Options - %s
184186
---------------- -----------%s
185187

186-
TXT
187-
, $tester->getDisplay(true));
188+
TXT,
189+
$tester->getDisplay(true)
190+
);
188191
}
189192

190193
#[DataProvider('provideCompletionSuggestions')]

0 commit comments

Comments
 (0)