Skip to content

Commit 5386477

Browse files
committed
Merge branch '2.3' into 2.6
* 2.3: [Validator] Add missing pt_BR translations Add parsing of hexadecimal strings for PHP 7 [Configuration] improve description for ignoreExtraKeys on ArrayNodeDefinition [Validator] Added missing Hungarian translation [Validator] Fixed grammar in Hungarian translation CS: Unary operators should be placed adjacent to their operands CS: Binary operators should be arounded by at least one space remove useless tests that fail in php 7 [Translator] fix test for php 7 compatibility Update phpdoc of ProcessBuilder#setPrefix() Conflicts: src/Symfony/Component/HttpFoundation/Session/Attribute/NamespacedAttributeBag.php src/Symfony/Component/PropertyAccess/PropertyAccessor.php src/Symfony/Component/Validator/Resources/translations/validators.pt_BR.xlf src/Symfony/Component/Yaml/Parser.php
2 parents 38da9b8 + 931d3db commit 5386477

File tree

2 files changed

+1
-11
lines changed

2 files changed

+1
-11
lines changed

Extension/Core/Type/ChoiceType.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ public function finishView(FormView $view, FormInterface $form, array $options)
163163
*/
164164
public function setDefaultOptions(OptionsResolverInterface $resolver)
165165
{
166-
$choiceListCache = & $this->choiceListCache;
166+
$choiceListCache = &$this->choiceListCache;
167167

168168
$choiceList = function (Options $options) use (&$choiceListCache) {
169169
// Harden against NULL values (like in EntityType and ModelType)

Tests/Extension/Core/Type/ChoiceTypeTest.php

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -66,16 +66,6 @@ protected function tearDown()
6666
$this->objectChoices = null;
6767
}
6868

69-
/**
70-
* @expectedException \PHPUnit_Framework_Error
71-
*/
72-
public function testChoicesOptionExpectsArray()
73-
{
74-
$this->factory->create('choice', null, array(
75-
'choices' => new \ArrayObject(),
76-
));
77-
}
78-
7969
/**
8070
* @expectedException \Symfony\Component\OptionsResolver\Exception\InvalidOptionsException
8171
*/

0 commit comments

Comments
 (0)