Merge branch '5.2' into 5.3

* 5.2:
  [5.2] Add missing `@return` annotations
  [4.4] Add missing `@return` annotations
  Handle lock with long key
  #42227 update phpdoc to recommend createIndex over ensureIndex

Author: nicolas-grekas

Button.php

@@ -63,6 +63,8 @@ public function offsetExists($offset)
      *
      * @param mixed $offset
      *
+     * @return mixed
+     *
      * @throws BadMethodCallException
      */
     public function offsetGet($offset)
@@ -78,6 +80,8 @@ public function offsetGet($offset)
      * @param mixed $offset
      * @param mixed $value
      *
+     * @return void
+     *
      * @throws BadMethodCallException
      */
     public function offsetSet($offset, $value)
@@ -92,6 +96,8 @@ public function offsetSet($offset, $value)
      *
      * @param mixed $offset
      *
+     * @return void
+     *
      * @throws BadMethodCallException
      */
     public function offsetUnset($offset)

Form.php

@@ -990,6 +990,8 @@ public function offsetGet($name)
      * @param string        $name  Ignored. The name of the child is used
      * @param FormInterface $child The child to be added
      *
+     * @return void
+     *
      * @throws AlreadySubmittedException if the form has already been submitted
      * @throws LogicException            when trying to add a child to a non-compound form
      *
@@ -1005,6 +1007,8 @@ public function offsetSet($name, $child)
      *
      * @param string $name The name of the child to remove
      *
+     * @return void
+     *
      * @throws AlreadySubmittedException if the form has already been submitted
      */
     public function offsetUnset($name)
@@ -1015,7 +1019,7 @@ public function offsetUnset($name)
     /**
      * Returns the iterator for this group.
      *
-     * @return \Traversable|FormInterface[]
+     * @return \Traversable<FormInterface>
      */
     public function getIterator()
     {

FormErrorIterator.php

@@ -170,6 +170,8 @@ public function offsetGet($position)
     /**
      * Unsupported method.
      *
+     * @return void
+     *
      * @throws BadMethodCallException
      */
     public function offsetSet($position, $value)
@@ -180,6 +182,8 @@ public function offsetSet($position, $value)
     /**
      * Unsupported method.
      *
+     * @return void
+     *
      * @throws BadMethodCallException
      */
     public function offsetUnset($position)
@@ -200,6 +204,8 @@ public function hasChildren()
 
     /**
      * Alias of {@link current()}.
+     *
+     * @return self
      */
     public function getChildren()
     {
@@ -233,6 +239,8 @@ public function count()
      *
      * @param int $position The new position
      *
+     * @return void
+     *
      * @throws OutOfBoundsException If the position is invalid
      */
     public function seek($position)

FormView.php

@@ -128,6 +128,8 @@ public function offsetExists($name)
     /**
      * Implements \ArrayAccess.
      *
+     * @return void
+     *
      * @throws BadMethodCallException always as setting a child by name is not allowed
      */
     public function offsetSet($name, $value)
@@ -139,6 +141,8 @@ public function offsetSet($name, $value)
      * Removes a child (implements \ArrayAccess).
      *
      * @param string $name The child name
+     *
+     * @return void
      */
     public function offsetUnset($name)
     {

Util/InheritDataAwareIterator.php

@@ -27,6 +27,8 @@ class InheritDataAwareIterator extends \IteratorIterator implements \RecursiveIt
 {
     /**
      * {@inheritdoc}
+     *
+     * @return static
      */
     public function getChildren()
     {

Util/OrderedHashMap.php

@@ -108,6 +108,8 @@ public function offsetExists($key)
 
     /**
      * {@inheritdoc}
+     *
+     * @return mixed
      */
     public function offsetGet($key)
     {
@@ -120,6 +122,8 @@ public function offsetGet($key)
 
     /**
      * {@inheritdoc}
+     *
+     * @return void
      */
     public function offsetSet($key, $value)
     {
@@ -141,6 +145,8 @@ public function offsetSet($key, $value)
 
     /**
      * {@inheritdoc}
+     *
+     * @return void
      */
     public function offsetUnset($key)
     {

Util/OrderedHashMapIterator.php

@@ -76,6 +76,9 @@ public function __construct(array &$elements, array &$orderedKeys, array &$manag
         $this->managedCursors[$this->cursorId] = &$this->cursor;
     }
 
+    /**
+     * @return array
+     */
     public function __sleep()
     {
         throw new \BadMethodCallException('Cannot serialize '.__CLASS__);
@@ -99,6 +102,8 @@ public function __destruct()
 
     /**
      * {@inheritdoc}
+     *
+     * @return mixed
      */
     public function current()
     {
@@ -107,6 +112,8 @@ public function current()
 
     /**
      * {@inheritdoc}
+     *
+     * @return void
      */
     public function next()
     {
@@ -123,6 +130,8 @@ public function next()
 
     /**
      * {@inheritdoc}
+     *
+     * @return mixed
      */
     public function key()
     {
@@ -145,6 +154,8 @@ public function valid(): bool
 
     /**
      * {@inheritdoc}
+     *
+     * @return void
      */
     public function rewind()
     {