bug #43392 [Form] Check the type of the constraints option (derrabus)

This PR was merged into the 5.4 branch.

Discussion
----------

[Form] Check the type of the constraints option

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #40726
| License       | MIT
| Doc PR        | N/A

This PR adds a type check to the constraints passed to a form field. This should improve the error message the developer receives in cases like the one described in #40726.

Commits
-------

04925da80f [Form] Check the type of the constraints option

Author: fabpot

Extension/Validator/Type/FormTypeValidatorExtension.php

@@ -18,6 +18,7 @@
 use Symfony\Component\Form\FormRendererInterface;
 use Symfony\Component\OptionsResolver\Options;
 use Symfony\Component\OptionsResolver\OptionsResolver;
+use Symfony\Component\Validator\Constraint;
 use Symfony\Component\Validator\Validator\ValidatorInterface;
 use Symfony\Contracts\Translation\TranslatorInterface;
 
@@ -66,6 +67,7 @@ public function configureOptions(OptionsResolver $resolver)
             'allow_extra_fields' => false,
             'extra_fields_message' => 'This form should not contain extra fields.',
         ]);
+        $resolver->setAllowedTypes('constraints', [Constraint::class, Constraint::class.'[]']);
         $resolver->setAllowedTypes('legacy_error_messages', 'bool');
         $resolver->setDeprecated('legacy_error_messages', 'symfony/form', '5.2', function (Options $options, $value) {
             if (true === $value) {

Tests/Extension/Validator/Type/FormTypeValidatorExtensionTest.php

@@ -19,6 +19,7 @@
 use Symfony\Component\Form\Tests\Extension\Core\Type\FormTypeTest;
 use Symfony\Component\Form\Tests\Extension\Core\Type\TextTypeTest;
 use Symfony\Component\Form\Tests\Fixtures\Author;
+use Symfony\Component\OptionsResolver\Exception\InvalidOptionsException;
 use Symfony\Component\Validator\Constraints\GroupSequence;
 use Symfony\Component\Validator\Constraints\Length;
 use Symfony\Component\Validator\Constraints\NotBlank;
@@ -61,6 +62,19 @@ public function testValidConstraint()
         $this->assertSame([$valid], $form->getConfig()->getOption('constraints'));
     }
 
+    public function testValidConstraintsArray()
+    {
+        $form = $this->createForm(['constraints' => [$valid = new Valid()]]);
+
+        $this->assertSame([$valid], $form->getConfig()->getOption('constraints'));
+    }
+
+    public function testInvalidConstraint()
+    {
+        $this->expectException(InvalidOptionsException::class);
+        $this->createForm(['constraints' => ['foo' => 'bar']]);
+    }
+
     public function testGroupSequenceWithConstraintsOption()
     {
         $form = Forms::createFormFactoryBuilder()