Merge branch '5.4' into 6.0

* 5.4:
  [Security] Deprecate legacy remember me services
  [Form] Fix return types in form builder

Author: nicolas-grekas

ButtonBuilder.php

@@ -412,10 +412,12 @@ public function setIsEmptyCallback(?callable $isEmptyCallback): static
 
     /**
      * Unsupported method.
+     *
+     * @throws BadMethodCallException
      */
     public function getEventDispatcher()
     {
-        return null;
+        throw new BadMethodCallException('Buttons do not support event dispatching.');
     }
 
     /**
@@ -606,26 +608,32 @@ public function getFormFactory()
 
     /**
      * Unsupported method.
+     *
+     * @throws BadMethodCallException
      */
     public function getAction()
     {
-        return null;
+        throw new BadMethodCallException('Buttons do not support actions.');
     }
 
     /**
      * Unsupported method.
+     *
+     * @throws BadMethodCallException
      */
     public function getMethod()
     {
-        return null;
+        throw new BadMethodCallException('Buttons do not support methods.');
     }
 
     /**
      * Unsupported method.
+     *
+     * @throws BadMethodCallException
      */
     public function getRequestHandler()
     {
-        return null;
+        throw new BadMethodCallException('Buttons do not support request handlers.');
     }
 
     /**

FormConfigBuilder.php

@@ -54,7 +54,7 @@ class FormConfigBuilder implements FormConfigBuilderInterface
     private ?string $dataClass;
     private bool $dataLocked = false;
     private ?FormFactoryInterface $formFactory = null;
-    private ?string $action = null;
+    private string $action;
     private string $method = 'POST';
     private RequestHandlerInterface $requestHandler;
     private bool $autoInitialize = false;
@@ -353,6 +353,10 @@ public function getDataLocked()
      */
     public function getFormFactory()
     {
+        if (!isset($this->formFactory)) {
+            throw new BadMethodCallException('The form factory must be set before retrieving it.');
+        }
+
         return $this->formFactory;
     }