[2.6] add @group legacy

nicolas-grekas · nicolas-grekas · commit e222853aeb7d · 2015-03-13T18:37:22.000+01:00
diff --git a/Tests/Extension/Core/ChoiceList/AbstractChoiceListTest.php b/Tests/Extension/Core/ChoiceList/AbstractChoiceListTest.php
@@ -161,6 +161,9 @@ public function testGetValues()
         $this->assertSame($this->values, $this->list->getValues());
     }
 
+    /**
+     * @group legacy
+     */
     public function testLegacyGetIndicesForChoices()
     {
         $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
@@ -169,6 +172,9 @@ public function testLegacyGetIndicesForChoices()
         $this->assertSame(array($this->index1, $this->index2), $this->list->getIndicesForChoices($choices));
     }
 
+    /**
+     * @group legacy
+     */
     public function testLegacyGetIndicesForChoicesPreservesKeys()
     {
         $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
@@ -177,6 +183,9 @@ public function testLegacyGetIndicesForChoicesPreservesKeys()
         $this->assertSame(array(5 => $this->index1, 8 => $this->index2), $this->list->getIndicesForChoices($choices));
     }
 
+    /**
+     * @group legacy
+     */
     public function testLegacyGetIndicesForChoicesPreservesOrder()
     {
         $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
@@ -185,6 +194,9 @@ public function testLegacyGetIndicesForChoicesPreservesOrder()
         $this->assertSame(array($this->index2, $this->index1), $this->list->getIndicesForChoices($choices));
     }
 
+    /**
+     * @group legacy
+     */
     public function testLegacyGetIndicesForChoicesIgnoresNonExistingChoices()
     {
         $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
@@ -193,13 +205,19 @@ public function testLegacyGetIndicesForChoicesIgnoresNonExistingChoices()
         $this->assertSame(array($this->index1, $this->index2), $this->list->getIndicesForChoices($choices));
     }
 
+    /**
+     * @group legacy
+     */
     public function testLegacyGetIndicesForChoicesEmpty()
     {
         $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
 
         $this->assertSame(array(), $this->list->getIndicesForChoices(array()));
     }
 
+    /**
+     * @group legacy
+     */
     public function testLegacyGetIndicesForValues()
     {
         $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
@@ -209,6 +227,9 @@ public function testLegacyGetIndicesForValues()
         $this->assertSame(array($this->index1, $this->index2), $this->list->getIndicesForValues($values));
     }
 
+    /**
+     * @group legacy
+     */
     public function testLegacyGetIndicesForValuesPreservesKeys()
     {
         $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
@@ -218,6 +239,9 @@ public function testLegacyGetIndicesForValuesPreservesKeys()
         $this->assertSame(array(5 => $this->index1, 8 => $this->index2), $this->list->getIndicesForValues($values));
     }
 
+    /**
+     * @group legacy
+     */
     public function testLegacyGetIndicesForValuesPreservesOrder()
     {
         $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
@@ -226,6 +250,9 @@ public function testLegacyGetIndicesForValuesPreservesOrder()
         $this->assertSame(array($this->index2, $this->index1), $this->list->getIndicesForValues($values));
     }
 
+    /**
+     * @group legacy
+     */
     public function testLegacyGetIndicesForValuesIgnoresNonExistingValues()
     {
         $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
@@ -234,6 +261,9 @@ public function testLegacyGetIndicesForValuesIgnoresNonExistingValues()
         $this->assertSame(array($this->index1, $this->index2), $this->list->getIndicesForValues($values));
     }
 
+    /**
+     * @group legacy
+     */
     public function testLegacyGetIndicesForValuesEmpty()
     {
         $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
diff --git a/Tests/Extension/Core/ChoiceList/LazyChoiceListTest.php b/Tests/Extension/Core/ChoiceList/LazyChoiceListTest.php
@@ -57,6 +57,9 @@ public function testGetRemainingViews()
         $this->assertEquals(array(0 => new ChoiceView('a', 'a', 'A'), 2 => new ChoiceView('c', 'c', 'C')), $this->list->getRemainingViews());
     }
 
+    /**
+     * @group legacy
+     */
     public function testLegacyGetIndicesForChoices()
     {
         $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
@@ -65,6 +68,9 @@ public function testLegacyGetIndicesForChoices()
         $this->assertSame(array(1, 2), $this->list->getIndicesForChoices($choices));
     }
 
+    /**
+     * @group legacy
+     */
     public function testLegacyGetIndicesForValues()
     {
         $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
diff --git a/Tests/Extension/Core/ChoiceList/ObjectChoiceListTest.php b/Tests/Extension/Core/ChoiceList/ObjectChoiceListTest.php
@@ -185,6 +185,9 @@ public function testInitArrayThrowsExceptionIfToStringNotFound()
         );
     }
 
+    /**
+     * @group legacy
+     */
     public function testLegacyGetIndicesForChoicesWithValuePath()
     {
         $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
@@ -202,6 +205,9 @@ public function testLegacyGetIndicesForChoicesWithValuePath()
         $this->assertSame(array($this->index1, $this->index2), $this->list->getIndicesForChoices($choices));
     }
 
+    /**
+     * @group legacy
+     */
     public function testLegacyGetIndicesForChoicesWithValuePathPreservesKeys()
     {
         $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
@@ -218,6 +224,9 @@ public function testLegacyGetIndicesForChoicesWithValuePathPreservesKeys()
         $this->assertSame(array(5 => $this->index1, 8 => $this->index2), $this->list->getIndicesForChoices($choices));
     }
 
+    /**
+     * @group legacy
+     */
     public function testLegacyGetIndicesForChoicesWithValuePathPreservesOrder()
     {
         $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
@@ -234,6 +243,9 @@ public function testLegacyGetIndicesForChoicesWithValuePathPreservesOrder()
         $this->assertSame(array($this->index2, $this->index1), $this->list->getIndicesForChoices($choices));
     }
 
+    /**
+     * @group legacy
+     */
     public function testLegacyGetIndicesForChoicesWithValuePathIgnoresNonExistingChoices()
     {
         $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
diff --git a/Tests/Extension/Core/ChoiceList/SimpleNumericChoiceListTest.php b/Tests/Extension/Core/ChoiceList/SimpleNumericChoiceListTest.php
@@ -15,6 +15,9 @@
 
 class SimpleNumericChoiceListTest extends AbstractChoiceListTest
 {
+    /**
+     * @group legacy
+     */
     public function testLegacyGetIndicesForChoicesDealsWithNumericChoices()
     {
         $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
@@ -24,6 +27,9 @@ public function testLegacyGetIndicesForChoicesDealsWithNumericChoices()
         $this->assertSame(array(0, 1), $this->list->getIndicesForChoices($choices));
     }
 
+    /**
+     * @group legacy
+     */
     public function testLegacyGetIndicesForValuesDealsWithNumericValues()
     {
         $this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);
diff --git a/Tests/Extension/Csrf/CsrfProvider/LegacyDefaultCsrfProviderTest.php b/Tests/Extension/Csrf/CsrfProvider/LegacyDefaultCsrfProviderTest.php
@@ -16,8 +16,9 @@
 /**
  * @runTestsInSeparateProcesses
  * @preserveGlobalState disabled
+ * @group legacy
  */
-class DefaultCsrfProviderTest extends \PHPUnit_Framework_TestCase
+class LegacyDefaultCsrfProviderTest extends \PHPUnit_Framework_TestCase
 {
     protected $provider;
 
diff --git a/Tests/Extension/Csrf/CsrfProvider/LegacySessionCsrfProviderTest.php b/Tests/Extension/Csrf/CsrfProvider/LegacySessionCsrfProviderTest.php
@@ -13,6 +13,9 @@
 
 use Symfony\Component\Form\Extension\Csrf\CsrfProvider\SessionCsrfProvider;
 
+/**
+ * @group legacy
+ */
 class LegacySessionCsrfProviderTest extends \PHPUnit_Framework_TestCase
 {
     protected $provider;
diff --git a/Tests/Extension/Validator/Constraints/LegacyFormValidator2Dot4ApiTest.php b/Tests/Extension/Validator/Constraints/LegacyFormValidator2Dot4ApiTest.php
@@ -16,6 +16,7 @@
 /**
  * @since  2.5.3
  * @author Bernhard Schussek <bschussek@gmail.com>
+ * @group  legacy
  */
 class LegacyFormValidator2Dot4ApiTest extends FormValidatorTest
 {
diff --git a/Tests/Extension/Validator/Constraints/LegacyFormValidatorLegacyApiTest.php b/Tests/Extension/Validator/Constraints/LegacyFormValidatorLegacyApiTest.php
@@ -16,6 +16,7 @@
 /**
  * @since  2.5.3
  * @author Bernhard Schussek <bschussek@gmail.com>
+ * @group  legacy
  */
 class LegacyFormValidatorLegacyApiTest extends FormValidatorTest
 {

Original file line number	Diff line number	Diff line change
`@@ -161,6 +161,9 @@ public function testGetValues()`
`161`	`161`	`$this->assertSame($this->values, $this->list->getValues());`
`162`	`162`	`}`
`163`	`163`
	`164`	`+ /**`
	`165`	`+ * @group legacy`
	`166`	`+ */`
`164`	`167`	`public function testLegacyGetIndicesForChoices()`
`165`	`168`	`{`
`166`	`169`	`$this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);`
`@@ -169,6 +172,9 @@ public function testLegacyGetIndicesForChoices()`
`169`	`172`	`$this->assertSame(array($this->index1, $this->index2), $this->list->getIndicesForChoices($choices));`
`170`	`173`	`}`
`171`	`174`
	`175`	`+ /**`
	`176`	`+ * @group legacy`
	`177`	`+ */`
`172`	`178`	`public function testLegacyGetIndicesForChoicesPreservesKeys()`
`173`	`179`	`{`
`174`	`180`	`$this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);`
`@@ -177,6 +183,9 @@ public function testLegacyGetIndicesForChoicesPreservesKeys()`
`177`	`183`	`$this->assertSame(array(5 => $this->index1, 8 => $this->index2), $this->list->getIndicesForChoices($choices));`
`178`	`184`	`}`
`179`	`185`
	`186`	`+ /**`
	`187`	`+ * @group legacy`
	`188`	`+ */`
`180`	`189`	`public function testLegacyGetIndicesForChoicesPreservesOrder()`
`181`	`190`	`{`
`182`	`191`	`$this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);`
`@@ -185,6 +194,9 @@ public function testLegacyGetIndicesForChoicesPreservesOrder()`
`185`	`194`	`$this->assertSame(array($this->index2, $this->index1), $this->list->getIndicesForChoices($choices));`
`186`	`195`	`}`
`187`	`196`
	`197`	`+ /**`
	`198`	`+ * @group legacy`
	`199`	`+ */`
`188`	`200`	`public function testLegacyGetIndicesForChoicesIgnoresNonExistingChoices()`
`189`	`201`	`{`
`190`	`202`	`$this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);`
`@@ -193,13 +205,19 @@ public function testLegacyGetIndicesForChoicesIgnoresNonExistingChoices()`
`193`	`205`	`$this->assertSame(array($this->index1, $this->index2), $this->list->getIndicesForChoices($choices));`
`194`	`206`	`}`
`195`	`207`
	`208`	`+ /**`
	`209`	`+ * @group legacy`
	`210`	`+ */`
`196`	`211`	`public function testLegacyGetIndicesForChoicesEmpty()`
`197`	`212`	`{`
`198`	`213`	`$this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);`
`199`	`214`
`200`	`215`	`$this->assertSame(array(), $this->list->getIndicesForChoices(array()));`
`201`	`216`	`}`
`202`	`217`
	`218`	`+ /**`
	`219`	`+ * @group legacy`
	`220`	`+ */`
`203`	`221`	`public function testLegacyGetIndicesForValues()`
`204`	`222`	`{`
`205`	`223`	`$this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);`
`@@ -209,6 +227,9 @@ public function testLegacyGetIndicesForValues()`
`209`	`227`	`$this->assertSame(array($this->index1, $this->index2), $this->list->getIndicesForValues($values));`
`210`	`228`	`}`
`211`	`229`
	`230`	`+ /**`
	`231`	`+ * @group legacy`
	`232`	`+ */`
`212`	`233`	`public function testLegacyGetIndicesForValuesPreservesKeys()`
`213`	`234`	`{`
`214`	`235`	`$this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);`
`@@ -218,6 +239,9 @@ public function testLegacyGetIndicesForValuesPreservesKeys()`
`218`	`239`	`$this->assertSame(array(5 => $this->index1, 8 => $this->index2), $this->list->getIndicesForValues($values));`
`219`	`240`	`}`
`220`	`241`
	`242`	`+ /**`
	`243`	`+ * @group legacy`
	`244`	`+ */`
`221`	`245`	`public function testLegacyGetIndicesForValuesPreservesOrder()`
`222`	`246`	`{`
`223`	`247`	`$this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);`
`@@ -226,6 +250,9 @@ public function testLegacyGetIndicesForValuesPreservesOrder()`
`226`	`250`	`$this->assertSame(array($this->index2, $this->index1), $this->list->getIndicesForValues($values));`
`227`	`251`	`}`
`228`	`252`
	`253`	`+ /**`
	`254`	`+ * @group legacy`
	`255`	`+ */`
`229`	`256`	`public function testLegacyGetIndicesForValuesIgnoresNonExistingValues()`
`230`	`257`	`{`
`231`	`258`	`$this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);`
`@@ -234,6 +261,9 @@ public function testLegacyGetIndicesForValuesIgnoresNonExistingValues()`
`234`	`261`	`$this->assertSame(array($this->index1, $this->index2), $this->list->getIndicesForValues($values));`
`235`	`262`	`}`
`236`	`263`
	`264`	`+ /**`
	`265`	`+ * @group legacy`
	`266`	`+ */`
`237`	`267`	`public function testLegacyGetIndicesForValuesEmpty()`
`238`	`268`	`{`
`239`	`269`	`$this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);`
Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,9 @@ public function testGetRemainingViews()`
`57`	`57`	`$this->assertEquals(array(0 => new ChoiceView('a', 'a', 'A'), 2 => new ChoiceView('c', 'c', 'C')), $this->list->getRemainingViews());`
`58`	`58`	`}`
`59`	`59`
	`60`	`+ /**`
	`61`	`+ * @group legacy`
	`62`	`+ */`
`60`	`63`	`public function testLegacyGetIndicesForChoices()`
`61`	`64`	`{`
`62`	`65`	`$this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);`
`@@ -65,6 +68,9 @@ public function testLegacyGetIndicesForChoices()`
`65`	`68`	`$this->assertSame(array(1, 2), $this->list->getIndicesForChoices($choices));`
`66`	`69`	`}`
`67`	`70`
	`71`	`+ /**`
	`72`	`+ * @group legacy`
	`73`	`+ */`
`68`	`74`	`public function testLegacyGetIndicesForValues()`
`69`	`75`	`{`
`70`	`76`	`$this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);`
Original file line number	Diff line number	Diff line change
`@@ -185,6 +185,9 @@ public function testInitArrayThrowsExceptionIfToStringNotFound()`
`185`	`185`	`);`
`186`	`186`	`}`
`187`	`187`
	`188`	`+ /**`
	`189`	`+ * @group legacy`
	`190`	`+ */`
`188`	`191`	`public function testLegacyGetIndicesForChoicesWithValuePath()`
`189`	`192`	`{`
`190`	`193`	`$this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);`
`@@ -202,6 +205,9 @@ public function testLegacyGetIndicesForChoicesWithValuePath()`
`202`	`205`	`$this->assertSame(array($this->index1, $this->index2), $this->list->getIndicesForChoices($choices));`
`203`	`206`	`}`
`204`	`207`
	`208`	`+ /**`
	`209`	`+ * @group legacy`
	`210`	`+ */`
`205`	`211`	`public function testLegacyGetIndicesForChoicesWithValuePathPreservesKeys()`
`206`	`212`	`{`
`207`	`213`	`$this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);`
`@@ -218,6 +224,9 @@ public function testLegacyGetIndicesForChoicesWithValuePathPreservesKeys()`
`218`	`224`	`$this->assertSame(array(5 => $this->index1, 8 => $this->index2), $this->list->getIndicesForChoices($choices));`
`219`	`225`	`}`
`220`	`226`
	`227`	`+ /**`
	`228`	`+ * @group legacy`
	`229`	`+ */`
`221`	`230`	`public function testLegacyGetIndicesForChoicesWithValuePathPreservesOrder()`
`222`	`231`	`{`
`223`	`232`	`$this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);`
`@@ -234,6 +243,9 @@ public function testLegacyGetIndicesForChoicesWithValuePathPreservesOrder()`
`234`	`243`	`$this->assertSame(array($this->index2, $this->index1), $this->list->getIndicesForChoices($choices));`
`235`	`244`	`}`
`236`	`245`
	`246`	`+ /**`
	`247`	`+ * @group legacy`
	`248`	`+ */`
`237`	`249`	`public function testLegacyGetIndicesForChoicesWithValuePathIgnoresNonExistingChoices()`
`238`	`250`	`{`
`239`	`251`	`$this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);`
Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,9 @@`
`15`	`15`
`16`	`16`	`class SimpleNumericChoiceListTest extends AbstractChoiceListTest`
`17`	`17`	`{`
	`18`	`+ /**`
	`19`	`+ * @group legacy`
	`20`	`+ */`
`18`	`21`	`public function testLegacyGetIndicesForChoicesDealsWithNumericChoices()`
`19`	`22`	`{`
`20`	`23`	`$this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);`
`@@ -24,6 +27,9 @@ public function testLegacyGetIndicesForChoicesDealsWithNumericChoices()`
`24`	`27`	`$this->assertSame(array(0, 1), $this->list->getIndicesForChoices($choices));`
`25`	`28`	`}`
`26`	`29`
	`30`	`+ /**`
	`31`	`+ * @group legacy`
	`32`	`+ */`
`27`	`33`	`public function testLegacyGetIndicesForValuesDealsWithNumericValues()`
`28`	`34`	`{`
`29`	`35`	`$this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,9 @@`
`13`	`13`
`14`	`14`	`use Symfony\Component\Form\Extension\Csrf\CsrfProvider\SessionCsrfProvider;`
`15`	`15`
	`16`	`+/**`
	`17`	`+ * @group legacy`
	`18`	`+ */`
`16`	`19`	`class LegacySessionCsrfProviderTest extends \PHPUnit_Framework_TestCase`
`17`	`20`	`{`
`18`	`21`	`protected $provider;`
Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@`
`16`	`16`	`/**`
`17`	`17`	`* @since 2.5.3`
`18`	`18`	`* @author Bernhard Schussek <[email protected]>`
	`19`	`+ * @group legacy`
`19`	`20`	`*/`
`20`	`21`	`class LegacyFormValidator2Dot4ApiTest extends FormValidatorTest`
`21`	`22`	`{`