Remove unnecessary usages of DateTime

Author: nicolas-grekas

Extension/Core/DataTransformer/DateTimeToArrayTransformer.php

@@ -67,10 +67,7 @@ public function transform(mixed $dateTime): array
         }
 
         if ($this->inputTimezone !== $this->outputTimezone) {
-            if (!$dateTime instanceof \DateTimeImmutable) {
-                $dateTime = clone $dateTime;
-            }
-
+            $dateTime = \DateTimeImmutable::createFromInterface($dateTime);
             $dateTime = $dateTime->setTimezone(new \DateTimeZone($this->outputTimezone));
         }
 

Extension/Core/DataTransformer/DateTimeToHtml5LocalDateTimeTransformer.php

@@ -53,10 +53,7 @@ public function transform(mixed $dateTime): string
         }
 
         if ($this->inputTimezone !== $this->outputTimezone) {
-            if (!$dateTime instanceof \DateTimeImmutable) {
-                $dateTime = clone $dateTime;
-            }
-
+            $dateTime = \DateTimeImmutable::createFromInterface($dateTime);
             $dateTime = $dateTime->setTimezone(new \DateTimeZone($this->outputTimezone));
         }
 

Extension/Core/DataTransformer/DateTimeToRfc3339Transformer.php

@@ -38,10 +38,7 @@ public function transform(mixed $dateTime): string
         }
 
         if ($this->inputTimezone !== $this->outputTimezone) {
-            if (!$dateTime instanceof \DateTimeImmutable) {
-                $dateTime = clone $dateTime;
-            }
-
+            $dateTime = \DateTimeImmutable::createFromInterface($dateTime);
             $dateTime = $dateTime->setTimezone(new \DateTimeZone($this->outputTimezone));
         }
 

Extension/Core/DataTransformer/DateTimeToStringTransformer.php

@@ -85,10 +85,7 @@ public function transform(mixed $dateTime): string
             throw new TransformationFailedException('Expected a \DateTimeInterface.');
         }
 
-        if (!$dateTime instanceof \DateTimeImmutable) {
-            $dateTime = clone $dateTime;
-        }
-
+        $dateTime = \DateTimeImmutable::createFromInterface($dateTime);
         $dateTime = $dateTime->setTimezone(new \DateTimeZone($this->outputTimezone));
 
         return $dateTime->format($this->generateFormat);

Extension/Core/Type/DateType.php

@@ -362,7 +362,7 @@ private function listYears(array $years): array
         $result = [];
 
         foreach ($years as $year) {
-            $result[\PHP_INT_SIZE === 4 ? \DateTime::createFromFormat('Y e', $year.' UTC')->format('U') : gmmktime(0, 0, 0, 6, 15, $year)] = $year;
+            $result[\PHP_INT_SIZE === 4 ? \DateTimeImmutable::createFromFormat('Y e', $year.' UTC')->format('U') : gmmktime(0, 0, 0, 6, 15, $year)] = $year;
         }
 
         return $result;

Extension/Validator/ValidatorTypeGuesser.php

@@ -115,6 +115,12 @@ public function guessTypeForConstraint(Constraint $constraint): ?TypeGuess
                     case '\DateTime':
                         return new TypeGuess(DateType::class, [], Guess::MEDIUM_CONFIDENCE);
 
+                    case \DateTimeImmutable::class:
+                    case '\DateTimeImmutable':
+                    case \DateTimeInterface::class:
+                    case '\DateTimeInterface':
+                        return new TypeGuess(DateType::class, ['input' => 'datetime_immutable'], Guess::MEDIUM_CONFIDENCE);
+
                     case 'string':
                         return new TypeGuess(TextType::class, [], Guess::LOW_CONFIDENCE);
                 }

Tests/Extension/Core/DataTransformer/Traits/DateTimeEqualsTrait.php

@@ -18,7 +18,7 @@ trait DateTimeEqualsTrait
 {
     public static function assertDateTimeEquals($expected, $actual)
     {
-        if ($expected instanceof \DateTime && $actual instanceof \DateTime) {
+        if ($expected instanceof \DateTimeInterface && $actual instanceof \DateTimeInterface) {
             $expected = $expected->format('c');
             $actual = $actual->format('c');
         }

Tests/Extension/Validator/ValidatorTypeGuesserTest.php

@@ -93,6 +93,7 @@ public static function guessTypeProvider()
             [new Type('long'), new TypeGuess(IntegerType::class, [], Guess::MEDIUM_CONFIDENCE)],
             [new Type('string'), new TypeGuess(TextType::class, [], Guess::LOW_CONFIDENCE)],
             [new Type(\DateTime::class), new TypeGuess(DateType::class, [], Guess::MEDIUM_CONFIDENCE)],
+            [new Type(\DateTimeImmutable::class), new TypeGuess(DateType::class, ['input' => 'datetime_immutable'], Guess::MEDIUM_CONFIDENCE)],
             [new Type('\DateTime'), new TypeGuess(DateType::class, [], Guess::MEDIUM_CONFIDENCE)],
         ];
     }