[Form] UrlType should not add protocol to emails

Author: GromNaN

Extension/Core/EventListener/FixUrlProtocolListener.php

@@ -36,7 +36,7 @@ public function onSubmit(FormEvent $event)
     {
         $data = $event->getData();
 
-        if ($this->defaultProtocol && $data && \is_string($data) && !preg_match('~^[\w+.-]+://~', $data)) {
+        if ($this->defaultProtocol && $data && \is_string($data) && !preg_match('~^([\w+.-]+://|[^:/?@#]++@)~', $data)) {
             $event->setData($this->defaultProtocol.'://'.$data);
         }
     }

Tests/Extension/Core/EventListener/FixUrlProtocolListenerTest.php

@@ -20,45 +20,49 @@
 
 class FixUrlProtocolListenerTest extends TestCase
 {
-    public function testFixHttpUrl()
+    public function provideUrlToFix()
     {
-        $data = 'www.symfony.com';
-        $form = new Form(new FormConfigBuilder('name', null, new EventDispatcher()));
-        $event = new FormEvent($form, $data);
-
-        $filter = new FixUrlProtocolListener('http');
-        $filter->onSubmit($event);
-
-        $this->assertEquals('http://www.symfony.com', $event->getData());
+        return [
+            ['www.symfony.com'],
+            ['twitter.com/@symfony'],
+            ['symfony.com?foo@bar'],
+            ['symfony.com#foo@bar'],
+            ['localhost'],
+        ];
     }
 
-    public function testSkipKnownUrl()
+    /**
+     * @dataProvider provideUrlToFix
+     */
+    public function testFixUrl($data)
     {
-        $data = 'http://www.symfony.com';
         $form = new Form(new FormConfigBuilder('name', null, new EventDispatcher()));
         $event = new FormEvent($form, $data);
 
         $filter = new FixUrlProtocolListener('http');
         $filter->onSubmit($event);
 
-        $this->assertEquals('http://www.symfony.com', $event->getData());
+        $this->assertEquals('http://'.$data, $event->getData());
     }
 
-    public function provideUrlsWithSupportedProtocols()
+    public function provideUrlToSkip()
     {
         return [
+            ['http://www.symfony.com'],
             ['ftp://www.symfony.com'],
+            ['https://twitter.com/@symfony'],
             ['chrome-extension://foo'],
             ['h323://foo'],
             ['iris.beep://foo'],
             ['foo+bar://foo'],
+            ['[email protected]'],
         ];
     }
 
     /**
-     * @dataProvider provideUrlsWithSupportedProtocols
+     * @dataProvider provideUrlToSkip
      */
-    public function testSkipOtherProtocol($url)
+    public function testSkipUrl($url)
     {
         $form = new Form(new FormConfigBuilder('name', null, new EventDispatcher()));
         $event = new FormEvent($form, $url);