[DI] Fix private-by-default BC layer

Author: nicolas-grekas

Tests/DependencyInjection/FormPassTest.php

@@ -51,8 +51,8 @@ public function testAddTaggedTypes()
         $container = $this->createContainerBuilder();
 
         $container->setDefinition('form.extension', $this->createExtensionDefinition());
-        $container->register('my.type1', __CLASS__.'_Type1')->addTag('form.type');
-        $container->register('my.type2', __CLASS__.'_Type2')->addTag('form.type');
+        $container->register('my.type1', __CLASS__.'_Type1')->addTag('form.type')->setPublic(true);
+        $container->register('my.type2', __CLASS__.'_Type2')->addTag('form.type')->setPublic(true);
 
         $container->compile();
 
@@ -73,8 +73,8 @@ public function testAddTaggedTypesToDebugCommand()
 
         $container->setDefinition('form.extension', $this->createExtensionDefinition());
         $container->setDefinition(DebugCommand::class, $this->createDebugCommandDefinition());
-        $container->register('my.type1', __CLASS__.'_Type1')->addTag('form.type');
-        $container->register('my.type2', __CLASS__.'_Type2')->addTag('form.type');
+        $container->register('my.type1', __CLASS__.'_Type1')->addTag('form.type')->setPublic(true);
+        $container->register('my.type2', __CLASS__.'_Type2')->addTag('form.type')->setPublic(true);
 
         $container->compile();
 
@@ -163,6 +163,7 @@ public function testAddTaggedFormTypeExtensionWithoutExtendedTypeAttribute()
 
         $container->setDefinition('form.extension', $this->createExtensionDefinition());
         $container->register('my.type_extension', 'stdClass')
+            ->setPublic(true)
             ->addTag('form.type_extension');
 
         $container->compile();
@@ -178,8 +179,8 @@ public function testAddTaggedGuessers()
         $definition2->addTag('form.type_guesser');
 
         $container->setDefinition('form.extension', $this->createExtensionDefinition());
-        $container->setDefinition('my.guesser1', $definition1);
-        $container->setDefinition('my.guesser2', $definition2);
+        $container->setDefinition('my.guesser1', $definition1)->setPublic(true);
+        $container->setDefinition('my.guesser2', $definition2)->setPublic(true);
 
         $container->compile();
 
@@ -249,6 +250,7 @@ function (ContainerBuilder $container) {
     private function createExtensionDefinition()
     {
         $definition = new Definition('Symfony\Component\Form\Extension\DependencyInjection\DependencyInjectionExtension');
+        $definition->setPublic(true);
         $definition->setArguments(array(
             array(),
             array(),
@@ -261,6 +263,7 @@ private function createExtensionDefinition()
     private function createDebugCommandDefinition()
     {
         $definition = new Definition('Symfony\Component\Form\Command\DebugCommand');
+        $definition->setPublic(true);
         $definition->setArguments(array(
             $formRegistry = $this->getMockBuilder(FormRegistryInterface::class)->getMock(),
             array(),