Skip to content

Commit 12b6885

Browse files
committed
feature #32241 [PropertyAccess] Deprecate null as allowed value for defaultLifetime argument in createCache method (jschaedl)
This PR was squashed before being merged into the 4.4 branch (closes #32241). Discussion ---------- [PropertyAccess] Deprecate null as allowed value for defaultLifetime argument in createCache method | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #32179 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A<!-- required for new features --> This PR is related to symfony/symfony#32234 (comment) Commits ------- 9aac42698a [PropertyAccess] Deprecate null as allowed value for defaultLifetime argument in createCache method
2 parents 6fa6996 + 0a2ecae commit 12b6885

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

DependencyInjection/FrameworkExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1869,7 +1869,7 @@ private function registerCacheConfiguration(array $config, ContainerBuilder $con
18691869

18701870
if (!$container->getParameter('kernel.debug')) {
18711871
$propertyAccessDefinition->setFactory([PropertyAccessor::class, 'createCache']);
1872-
$propertyAccessDefinition->setArguments([null, null, $version, new Reference('logger', ContainerInterface::IGNORE_ON_INVALID_REFERENCE)]);
1872+
$propertyAccessDefinition->setArguments([null, 0, $version, new Reference('logger', ContainerInterface::IGNORE_ON_INVALID_REFERENCE)]);
18731873
$propertyAccessDefinition->addTag('cache.pool', ['clearer' => 'cache.system_clearer']);
18741874
$propertyAccessDefinition->addTag('monolog.logger', ['channel' => 'cache']);
18751875
} else {

0 commit comments

Comments
 (0)