Skip to content

Commit 2198c50

Browse files
Merge branch '3.4'
* 3.4: fix merge fix merge [FORM] Prevent forms from extending itself as a parent fix merge Fix 7.2 compat layer [DI] Prefixed env vars and load time inlining are incompatible bug #24499 [Bridge\PhpUnit] Fix infinite loop when running isolated method (bis) (nicolas-grekas) Fix PHP 7.2 support [HttpFoundation] Add missing session.lazy_write config option [DI] Exclude inline services declared in XML from autowiring candidates [HttpFoundation] Combine Cache-Control headers [Form] fix parsing invalid floating point numbers Escape command usage when displaying it in the text descriptor [DI] Throw accurate failures when accessing removed services [DI] Turn private defs to non-public ones before removing passes Use for=ID on radio/checkbox label.
2 parents e234cd4 + 02eada7 commit 2198c50

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

Tests/Command/CacheClearCommand/CacheClearCommandTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public function testCacheIsFreshAfterCacheClearedWithWarmup()
5555
$finder = new Finder();
5656
$metaFiles = $finder->files()->in($this->kernel->getCacheDir())->name('*.php.meta');
5757
// simply check that cache is warmed up
58-
$this->assertGreaterThanOrEqual(1, count($metaFiles));
58+
$this->assertNotEmpty($metaFiles);
5959
$configCacheFactory = new ConfigCacheFactory(true);
6060

6161
foreach ($metaFiles as $file) {

Tests/Controller/ControllerTraitTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -373,6 +373,9 @@ public function testRedirectToRoute()
373373
$this->assertSame(302, $response->getStatusCode());
374374
}
375375

376+
/**
377+
* @runInSeparateProcess
378+
*/
376379
public function testAddFlash()
377380
{
378381
$flashBag = new FlashBag();

Tests/Fixtures/Validation/Article.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@
22

33
namespace Symfony\Bundle\FrameworkBundle\Tests\Fixtures\Validation;
44

5-
class Article implements NotExistingInterface
6-
{
7-
public $category;
5+
if (!function_exists('__phpunit_run_isolated_test')) {
6+
class Article implements NotExistingInterface
7+
{
8+
public $category;
9+
}
810
}

0 commit comments

Comments
 (0)