feature #35762 [Asset] Allows to download asset manifest over HTTP (GromNaN)

This PR was merged into the 5.1-dev branch.

Discussion
----------

[Asset] Allows to download asset manifest over HTTP

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Fix #35761 Fix #33001
| License       | MIT
| Doc PR        | symfony/symfony-docs#13255

```yaml
framework:
    assets:
        json_manifest_path: 'https://cdn.example.com/manifest.json'
```

Commits
-------

4ba12a80e5 [Asset] Allows to download json manifest from a remote url

Author: nicolas-grekas

DependencyInjection/FrameworkExtension.php

@@ -1057,7 +1057,12 @@ private function createVersion(ContainerBuilder $container, ?string $version, ?s
         }
 
         if (null !== $jsonManifestPath) {
-            $def = new ChildDefinition('assets.json_manifest_version_strategy');
+            $definitionName = 'assets.json_manifest_version_strategy';
+            if (0 === strpos(parse_url($jsonManifestPath, PHP_URL_SCHEME), 'http')) {
+                $definitionName = 'assets.remote_json_manifest_version_strategy';
+            }
+
+            $def = new ChildDefinition($definitionName);
             $def->replaceArgument(0, $jsonManifestPath);
             $container->setDefinition('assets._version_'.$name, $def);
 

Resources/config/assets.xml

@@ -50,5 +50,10 @@
         <service id="assets.json_manifest_version_strategy" class="Symfony\Component\Asset\VersionStrategy\JsonManifestVersionStrategy" abstract="true">
             <argument /> <!-- manifest path -->
         </service>
+
+        <service id="assets.remote_json_manifest_version_strategy" class="Symfony\Component\Asset\VersionStrategy\RemoteJsonManifestVersionStrategy" abstract="true">
+            <argument /> <!-- manifest url -->
+            <argument type="service" id="http_client" />
+        </service>
     </services>
 </container>

Tests/DependencyInjection/Fixtures/php/assets.php

@@ -27,6 +27,9 @@
             'json_manifest_strategy' => [
                 'json_manifest_path' => '/path/to/manifest.json',
             ],
+            'remote_manifest' => [
+                'json_manifest_path' => 'https://cdn.example.com/manifest.json',
+            ],
         ],
     ],
 ]);

Tests/DependencyInjection/Fixtures/xml/assets.xml

@@ -22,6 +22,7 @@
                 <framework:base-url>https://bar_version_strategy.example.com</framework:base-url>
             </framework:package>
             <framework:package name="json_manifest_strategy" json-manifest-path="/path/to/manifest.json" />
+            <framework:package name="remote_manifest" json-manifest-path="https://cdn.example.com/manifest.json" />
         </framework:assets>
     </framework:config>
 </container>

Tests/DependencyInjection/Fixtures/yml/assets.yml

@@ -19,3 +19,5 @@ framework:
                 version_strategy: assets.custom_version_strategy
             json_manifest_strategy:
                 json_manifest_path: '/path/to/manifest.json'
+            remote_manifest:
+                json_manifest_path: 'https://cdn.example.com/manifest.json'

Tests/DependencyInjection/FrameworkExtensionTest.php

@@ -535,7 +535,7 @@ public function testAssets()
 
         // packages
         $packages = $packages->getArgument(1);
-        $this->assertCount(6, $packages);
+        $this->assertCount(7, $packages);
 
         $package = $container->getDefinition((string) $packages['images_path']);
         $this->assertPathPackage($container, $package, '/foo', 'SomeVersionScheme', '%%s?version=%%s');
@@ -556,6 +556,11 @@ public function testAssets()
         $versionStrategy = $container->getDefinition((string) $package->getArgument(1));
         $this->assertEquals('assets.json_manifest_version_strategy', $versionStrategy->getParent());
         $this->assertEquals('/path/to/manifest.json', $versionStrategy->getArgument(0));
+
+        $package = $container->getDefinition($packages['remote_manifest']);
+        $versionStrategy = $container->getDefinition($package->getArgument(1));
+        $this->assertSame('assets.remote_json_manifest_version_strategy', $versionStrategy->getParent());
+        $this->assertSame('https://cdn.example.com/manifest.json', $versionStrategy->getArgument(0));
     }
 
     public function testAssetsDefaultVersionStrategyAsService()

composer.json

@@ -33,7 +33,7 @@
     "require-dev": {
         "doctrine/annotations": "~1.7",
         "doctrine/cache": "~1.0",
-        "symfony/asset": "^4.4|^5.0",
+        "symfony/asset": "^5.1",
         "symfony/browser-kit": "^4.4|^5.0",
         "symfony/console": "^4.4|^5.0",
         "symfony/css-selector": "^4.4|^5.0",
@@ -70,7 +70,7 @@
         "phpdocumentor/reflection-docblock": "<3.0",
         "phpdocumentor/type-resolver": "<0.2.1",
         "phpunit/phpunit": "<5.4.3",
-        "symfony/asset": "<4.4",
+        "symfony/asset": "<5.1",
         "symfony/browser-kit": "<4.4",
         "symfony/console": "<4.4",
         "symfony/dotenv": "<5.1",