Skip to content

Commit 37b8c28

Browse files
committed
bug #23088 [FrameworkBundle] Dont set pre-defined esi/ssi services (ro0NL)
This PR was squashed before being merged into the 3.3 branch (closes #23088). Discussion ---------- [FrameworkBundle] Dont set pre-defined esi/ssi services | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | not sure | Deprecations? | no | Tests pass? | yes/no | Fixed tickets | #23080 | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> It fixes the issue, but im not sure what's expected if you dont use http cache (solely enabled ssi/esi in config). Before the services were initialized, now they are synthetic as http cache sets them, but thats optional =/ Commits ------- 8c26aab0fe [FrameworkBundle] Dont set pre-defined esi/ssi services
2 parents d2fb85c + 9a86cde commit 37b8c28

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

HttpCache/HttpCache.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,7 @@ public function __construct(HttpKernelInterface $kernel, $cacheDir = null)
5454
protected function forward(Request $request, $raw = false, Response $entry = null)
5555
{
5656
$this->getKernel()->boot();
57-
$this->getKernel()->getContainer()->set('cache', $this);
58-
$this->getKernel()->getContainer()->set($this->getSurrogate()->getName(), $this->getSurrogate());
57+
$this->getKernel()->getContainer()->set('cache', $this); // to be removed in 4.0?
5958
6059
return parent::forward($request, $raw, $entry);
6160
}

0 commit comments

Comments
 (0)