Add return types to tests and final|internal|private methods

Author: nicolas-grekas

Test/TestContainer.php

@@ -97,6 +97,8 @@ public function has($id): bool
 
     /**
      * {@inheritdoc}
+     *
+     * @return object|null
      */
     public function get($id, $invalidBehavior = /* self::EXCEPTION_ON_INVALID_REFERENCE */ 1)
     {

Tests/Command/CacheClearCommand/Fixture/TestAppKernel.php

@@ -19,14 +19,14 @@
 
 class TestAppKernel extends Kernel
 {
-    public function registerBundles()
+    public function registerBundles(): iterable
     {
         return [
             new FrameworkBundle(),
         ];
     }
 
-    public function getProjectDir()
+    public function getProjectDir(): string
     {
         return __DIR__.'/test';
     }

Tests/Console/Descriptor/ObjectsProvider.php

@@ -202,7 +202,7 @@ public static function staticMethod()
 
 class RouteStub extends Route
 {
-    public function compile()
+    public function compile(): CompiledRoute
     {
         return new CompiledRoute('', '#PATH_REGEX#', [], [], '#HOST_REGEX#');
     }

Tests/DependencyInjection/Compiler/DataCollectorTranslatorPassTest.php

@@ -108,7 +108,7 @@ public function getNotImplementingTranslatorBagInterfaceTranslatorClassNames()
 
 class TranslatorWithTranslatorBag implements TranslatorInterface
 {
-    public function trans($id, array $parameters = [], $domain = null, $locale = null)
+    public function trans($id, array $parameters = [], $domain = null, $locale = null): string
     {
     }
 }

Tests/DependencyInjection/Fixtures/CustomPathBundle/src/CustomPathBundle.php

@@ -15,7 +15,7 @@
 
 class CustomPathBundle extends Bundle
 {
-    public function getPath()
+    public function getPath(): string
     {
         return __DIR__.'/..';
     }

Tests/Functional/AbstractWebTestCase.php

@@ -13,6 +13,7 @@
 
 use Symfony\Bundle\FrameworkBundle\Test\WebTestCase as BaseWebTestCase;
 use Symfony\Component\Filesystem\Filesystem;
+use Symfony\Component\HttpKernel\KernelInterface;
 
 abstract class AbstractWebTestCase extends BaseWebTestCase
 {
@@ -42,14 +43,14 @@ protected static function deleteTmpDir()
         $fs->remove($dir);
     }
 
-    protected static function getKernelClass()
+    protected static function getKernelClass(): string
     {
         require_once __DIR__.'/app/AppKernel.php';
 
         return 'Symfony\Bundle\FrameworkBundle\Tests\Functional\app\AppKernel';
     }
 
-    protected static function createKernel(array $options = [])
+    protected static function createKernel(array $options = []): KernelInterface
     {
         $class = self::getKernelClass();
 

Tests/Functional/AutowiringTypesTest.php

@@ -17,6 +17,7 @@
 use Symfony\Component\Cache\Adapter\FilesystemAdapter;
 use Symfony\Component\EventDispatcher\EventDispatcher;
 use Symfony\Component\HttpKernel\Debug\TraceableEventDispatcher;
+use Symfony\Component\HttpKernel\KernelInterface;
 use Symfony\Component\Templating\EngineInterface as ComponentEngineInterface;
 
 class AutowiringTypesTest extends AbstractWebTestCase
@@ -70,7 +71,7 @@ public function testCacheAutowiring()
         $this->assertInstanceOf(FilesystemAdapter::class, $autowiredServices->getCachePool());
     }
 
-    protected static function createKernel(array $options = [])
+    protected static function createKernel(array $options = []): KernelInterface
     {
         return parent::createKernel(['test_case' => 'AutowiringTypes'] + $options);
     }

Tests/Functional/Bundle/TestBundle/DependencyInjection/Configuration.php

@@ -23,7 +23,7 @@ public function __construct($customConfig = null)
         $this->customConfig = $customConfig;
     }
 
-    public function getConfigTreeBuilder()
+    public function getConfigTreeBuilder(): TreeBuilder
     {
         $treeBuilder = new TreeBuilder('test');
 

Tests/Functional/Bundle/TestBundle/DependencyInjection/TestExtension.php

@@ -11,6 +11,7 @@
 
 namespace Symfony\Bundle\FrameworkBundle\Tests\Functional\Bundle\TestBundle\DependencyInjection;
 
+use Symfony\Component\Config\Definition\ConfigurationInterface;
 use Symfony\Component\DependencyInjection\Alias;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Extension\Extension;
@@ -42,7 +43,7 @@ public function prepend(ContainerBuilder $container)
     /**
      * {@inheritdoc}
      */
-    public function getConfiguration(array $config, ContainerBuilder $container)
+    public function getConfiguration(array $config, ContainerBuilder $container): ?ConfigurationInterface
     {
         return new Configuration($this->customConfig);
     }

Tests/Functional/Bundle/TestBundle/TransDebug/TransSubscriberService.php

@@ -24,7 +24,7 @@ public function __construct(ContainerInterface $container)
         $this->container = $container;
     }
 
-    public static function getSubscribedServices()
+    public static function getSubscribedServices(): array
     {
         return ['translator' => TranslatorInterface::class];
     }