Skip to content

Commit 6acb9c5

Browse files
committed
Merge branch '6.4' into 7.0
* 6.4: Fix incompatibility between security-bundle 6.4 and security-http 7.0 [String] Update wcswidth data with Unicode 15.1 [FrameworkBundle] no serializer mapping cache in debug mode without enable_annotations [Cache] fix using multiple Redis Sentinel hosts when the first one is not resolvable
2 parents fced11a + b8415ba commit 6acb9c5

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

DependencyInjection/FrameworkExtension.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1818,16 +1818,16 @@ private function registerSerializerConfiguration(array $config, ContainerBuilder
18181818
$container->removeDefinition('serializer.normalizer.mime_message');
18191819
}
18201820

1821+
if ($container->getParameter('kernel.debug')) {
1822+
$container->removeDefinition('serializer.mapping.cache_class_metadata_factory');
1823+
}
1824+
18211825
if (!class_exists(Translator::class)) {
18221826
$container->removeDefinition('serializer.normalizer.translatable');
18231827
}
18241828

18251829
$serializerLoaders = [];
18261830
if (isset($config['enable_attributes']) && $config['enable_attributes']) {
1827-
if ($container->getParameter('kernel.debug')) {
1828-
$container->removeDefinition('serializer.mapping.cache_class_metadata_factory');
1829-
}
1830-
18311831
$annotationLoader = new Definition(AnnotationLoader::class);
18321832

18331833
$serializerLoaders[] = $annotationLoader;

Tests/DependencyInjection/FrameworkExtensionTestCase.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1548,6 +1548,12 @@ public function testSerializerCacheActivated()
15481548
public function testSerializerCacheUsedWithoutAnnotationsAndMappingFiles()
15491549
{
15501550
$container = $this->createContainerFromFile('serializer_mapping_without_annotations', ['kernel.debug' => true, 'kernel.container_class' => __CLASS__]);
1551+
$this->assertFalse($container->hasDefinition('serializer.mapping.cache_class_metadata_factory'));
1552+
}
1553+
1554+
public function testSerializerCacheUsedWithoutAnnotationsAndMappingFilesNoDebug()
1555+
{
1556+
$container = $this->createContainerFromFile('serializer_mapping_without_annotations', ['kernel.debug' => false, 'kernel.container_class' => __CLASS__]);
15511557
$this->assertTrue($container->hasDefinition('serializer.mapping.cache_class_metadata_factory'));
15521558
}
15531559

0 commit comments

Comments
 (0)