Skip to content

Commit 70170da

Browse files
committed
Merge branch '5.0'
* 5.0: register only existing transport factories prevent deprecation being triggered from assertion bumped Symfony version to 5.0.6 updated VERSION for 5.0.5 updated CHANGELOG for 5.0.5 bumped Symfony version to 4.4.6 updated VERSION for 4.4.5 updated CHANGELOG for 4.4.5
2 parents eed0734 + 6e45b1d commit 70170da

File tree

2 files changed

+16
-18
lines changed

2 files changed

+16
-18
lines changed

DependencyInjection/FrameworkExtension.php

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -321,20 +321,14 @@ public function load(array $configs, ContainerBuilder $container)
321321
$container->removeDefinition('console.command.messenger_failed_messages_remove');
322322
$container->removeDefinition('cache.messenger.restart_workers_signal');
323323

324-
if ($container->hasDefinition('messenger.transport.amqp.factory') && !class_exists(AmqpTransportFactory::class)) {
325-
if (class_exists(\Symfony\Component\Messenger\Transport\AmqpExt\AmqpTransportFactory::class)) {
326-
$container->getDefinition('messenger.transport.amqp.factory')->setClass(\Symfony\Component\Messenger\Transport\AmqpExt\AmqpTransportFactory::class);
327-
} else {
328-
$container->removeDefinition('messenger.transport.amqp.factory');
329-
}
324+
if ($container->hasDefinition('messenger.transport.amqp.factory') && class_exists(AmqpTransportFactory::class)) {
325+
$container->getDefinition('messenger.transport.amqp.factory')
326+
->addTag('messenger.transport_factory');
330327
}
331328

332-
if ($container->hasDefinition('messenger.transport.redis.factory') && !class_exists(RedisTransportFactory::class)) {
333-
if (class_exists(\Symfony\Component\Messenger\Transport\RedisExt\RedisTransportFactory::class)) {
334-
$container->getDefinition('messenger.transport.redis.factory')->setClass(\Symfony\Component\Messenger\Transport\RedisExt\RedisTransportFactory::class);
335-
} else {
336-
$container->removeDefinition('messenger.transport.redis.factory');
337-
}
329+
if ($container->hasDefinition('messenger.transport.redis.factory') && class_exists(RedisTransportFactory::class)) {
330+
$container->getDefinition('messenger.transport.redis.factory')
331+
->addTag('messenger.transport_factory');
338332
}
339333
}
340334

@@ -1613,6 +1607,14 @@ private function registerMessengerConfiguration(array $config, ContainerBuilder
16131607

16141608
$loader->load('messenger.xml');
16151609

1610+
if (class_exists(AmqpTransportFactory::class)) {
1611+
$container->getDefinition('messenger.transport.amqp.factory')->addTag('messenger.transport_factory');
1612+
}
1613+
1614+
if (class_exists(RedisTransportFactory::class)) {
1615+
$container->getDefinition('messenger.transport.redis.factory')->addTag('messenger.transport_factory');
1616+
}
1617+
16161618
if (null === $config['default_bus'] && 1 === \count($config['buses'])) {
16171619
$config['default_bus'] = key($config['buses']);
16181620
}

Resources/config/messenger.xml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,13 +67,9 @@
6767
<argument type="tagged_iterator" tag="messenger.transport_factory" />
6868
</service>
6969

70-
<service id="messenger.transport.amqp.factory" class="Symfony\Component\Messenger\Bridge\Amqp\Transport\AmqpTransportFactory">
71-
<tag name="messenger.transport_factory" />
72-
</service>
70+
<service id="messenger.transport.amqp.factory" class="Symfony\Component\Messenger\Bridge\Amqp\Transport\AmqpTransportFactory"/>
7371

74-
<service id="messenger.transport.redis.factory" class="Symfony\Component\Messenger\Bridge\Redis\Transport\RedisTransportFactory">
75-
<tag name="messenger.transport_factory" />
76-
</service>
72+
<service id="messenger.transport.redis.factory" class="Symfony\Component\Messenger\Bridge\Redis\Transport\RedisTransportFactory"/>
7773

7874
<service id="messenger.transport.sync.factory" class="Symfony\Component\Messenger\Transport\Sync\SyncTransportFactory">
7975
<tag name="messenger.transport_factory" />

0 commit comments

Comments
 (0)