minor #43203 [FrameworkBundle] Make the messenger.reset_on_message config option default to true (upyx)

This PR was merged into the 6.0 branch.

Discussion
----------

[FrameworkBundle] Make the messenger.reset_on_message config option default to true

| Q             | A
| ------------- | ---
| Branch?       | 6.0
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | no
| License       | MIT
| Doc PR        | no

It changes the "framework.messenger.reset_on_message" configuration option to true and changes deprecation warnings.

~It's waiting fixes from #43202~

Commits
-------

e3eecd1507 [FrameworkBundle] Make the messenger.reset_on_message config option default to true

Author: fabpot

CHANGELOG.md

@@ -1422,8 +1422,12 @@ function ($a) {
                             ->info('Transport name to send failed messages to (after all retries have failed).')
                         ->end()
                         ->booleanNode('reset_on_message')
-                            ->defaultNull()
+                            ->defaultTrue()
                             ->info('Reset container services after each message.')
+                            ->validate()
+                                ->ifTrue(static fn ($v) => true !== $v)
+                                ->thenInvalid('The "framework.messenger.reset_on_message" configuration option can be set to "true" only. To prevent services resetting after each message you can set the "--no-reset" option in "messenger:consume" command.')
+                            ->end()
                         ->end()
                         ->scalarNode('default_bus')->defaultNull()->end()
                         ->arrayNode('buses')

DependencyInjection/Configuration.php

@@ -2067,17 +2067,8 @@ private function registerMessengerConfiguration(array $config, ContainerBuilder
             $container->removeDefinition('console.command.messenger_failed_messages_remove');
         }
 
-        if (false === $config['reset_on_message']) {
-            throw new LogicException('The "framework.messenger.reset_on_message" configuration option can be set to "true" only. To prevent services resetting after each message you can set the "--no-reset" option in "messenger:consume" command.');
-        }
-
         if (!$container->hasDefinition('console.command.messenger_consume_messages')) {
             $container->removeDefinition('messenger.listener.reset_services');
-        } elseif (null === $config['reset_on_message']) {
-            trigger_deprecation('symfony/framework-bundle', '5.4', 'Not setting the "framework.messenger.reset_on_message" configuration option is deprecated, it will default to "true" in version 6.0.');
-
-            $container->getDefinition('console.command.messenger_consume_messages')->replaceArgument(5, null);
-            $container->removeDefinition('messenger.listener.reset_services');
         }
     }
 

DependencyInjection/FrameworkExtension.php

@@ -536,7 +536,7 @@ class_exists(SemaphoreStore::class) && SemaphoreStore::isSupported() ? 'semaphor
                 ],
                 'default_bus' => null,
                 'buses' => ['messenger.bus.default' => ['default_middleware' => true, 'middleware' => []]],
-                'reset_on_message' => null,
+                'reset_on_message' => true,
             ],
             'disallow_search_engine_index' => true,
             'http_client' => [

Tests/DependencyInjection/ConfigurationTest.php

@@ -5,7 +5,6 @@
 
 $container->loadFromExtension('framework', [
     'messenger' => [
-        'reset_on_message' =>  true,
         'routing' => [
             FooMessage::class => ['sender.bar', 'sender.biz'],
             BarMessage::class => 'sender.foo',

Tests/DependencyInjection/Fixtures/php/messenger.php

@@ -2,7 +2,6 @@
 
 $container->loadFromExtension('framework', [
     'messenger' => [
-        'reset_on_message' =>  true,
         'buses' => [
             'command_bus' => [
                 'middleware' => [

Tests/DependencyInjection/Fixtures/php/messenger_middleware_factory_erroneous_format.php

@@ -2,7 +2,6 @@
 
 $container->loadFromExtension('framework', [
     'messenger' => [
-        'reset_on_message' =>  true,
         'default_bus' => 'messenger.bus.commands',
         'buses' => [
             'messenger.bus.commands' => null,

Tests/DependencyInjection/Fixtures/php/messenger_multiple_buses.php

@@ -2,7 +2,6 @@
 
 $container->loadFromExtension('framework', [
     'messenger' => [
-        'reset_on_message' =>  true,
         'transports' => [
             'transport_1' => [
                 'dsn' => 'null://',

Tests/DependencyInjection/Fixtures/php/messenger_multiple_failure_transports.php

@@ -3,7 +3,6 @@
 $container->loadFromExtension('framework', [
     'messenger' => [
         'failure_transport' => 'failure_transport_global',
-        'reset_on_message' =>  true,
         'transports' => [
             'transport_1' => [
                 'dsn' => 'null://',

Tests/DependencyInjection/Fixtures/php/messenger_multiple_failure_transports_global.php

@@ -3,7 +3,6 @@
 $container->loadFromExtension('framework', [
     'serializer' => true,
     'messenger' => [
-        'reset_on_message' =>  true,
         'serializer' => [
             'default_serializer' => 'messenger.transport.symfony_serializer',
         ],