Skip to content

Commit 80325b9

Browse files
committed
fix tests to not depend on the installation of the redis extension
1 parent f4c9f5b commit 80325b9

File tree

7 files changed

+0
-18
lines changed

7 files changed

+0
-18
lines changed

Tests/DependencyInjection/Fixtures/php/lock_service.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
<?php
22

33
$container->register('my_service', \Redis::class);
4-
$container->setAlias('factory_public_alias', 'lock.default.factory')
5-
->setPublic(true);
64

75
$container->loadFromExtension('framework', [
86
'annotations' => false,

Tests/DependencyInjection/Fixtures/php/semaphore_service.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
<?php
22

33
$container->register('my_service', \Redis::class);
4-
$container->setAlias('factory_public_alias', 'semaphore.default.factory')
5-
->setPublic(true);
64

75
$container->loadFromExtension('framework', [
86
'annotations' => false,

Tests/DependencyInjection/Fixtures/xml/lock_service.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
<services>
99
<service id="my_service" class="\Redis" />
10-
<service id="factory_public_alias" alias="lock.default.factory" public="true" />
1110
</services>
1211

1312
<framework:config http-method-override="false" handle-all-throwables="true">

Tests/DependencyInjection/Fixtures/xml/semaphore_service.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
<services>
99
<service id="my_service" class="\Redis" />
10-
<service id="factory_public_alias" alias="semaphore.default.factory" public="true" />
1110
</services>
1211

1312
<framework:config http-method-override="false" handle-all-throwables="true">

Tests/DependencyInjection/Fixtures/yml/lock_service.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
services:
22
my_service:
33
class: \Redis
4-
factory_public_alias:
5-
alias: lock.default.factory
6-
public: true
74

85
framework:
96
annotations: false

Tests/DependencyInjection/Fixtures/yml/semaphore_service.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
11
services:
22
my_service:
33
class: \Redis
4-
factory_public_alias:
5-
alias: semaphore.default.factory
6-
public: true
74

85
framework:
96
annotations: false

Tests/DependencyInjection/FrameworkExtensionTestCase.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@
5858
use Symfony\Component\HttpFoundation\IpUtils;
5959
use Symfony\Component\HttpKernel\DependencyInjection\LoggerPass;
6060
use Symfony\Component\HttpKernel\Fragment\FragmentUriGeneratorInterface;
61-
use Symfony\Component\Lock\LockFactory;
6261
use Symfony\Component\Lock\Store\SemaphoreStore;
6362
use Symfony\Component\Messenger\Bridge\AmazonSqs\Transport\AmazonSqsTransportFactory;
6463
use Symfony\Component\Messenger\Bridge\Amqp\Transport\AmqpTransportFactory;
@@ -69,7 +68,6 @@
6968
use Symfony\Component\Notifier\TexterInterface;
7069
use Symfony\Component\PropertyAccess\PropertyAccessor;
7170
use Symfony\Component\Security\Core\AuthenticationEvents;
72-
use Symfony\Component\Semaphore\SemaphoreFactory;
7371
use Symfony\Component\Serializer\Mapping\Loader\AttributeLoader;
7472
use Symfony\Component\Serializer\Mapping\Loader\XmlFileLoader;
7573
use Symfony\Component\Serializer\Mapping\Loader\YamlFileLoader;
@@ -2465,8 +2463,6 @@ public function testLockWithService()
24652463
self::assertTrue($container->hasDefinition('lock.default.factory'));
24662464
$storeDef = $container->getDefinition($container->getDefinition('lock.default.factory')->getArgument(0));
24672465
self::assertEquals(new Reference('my_service'), $storeDef->getArgument(0));
2468-
2469-
self::assertInstanceOf(LockFactory::class, $container->get('factory_public_alias'));
24702466
}
24712467

24722468
public function testDefaultSemaphore()
@@ -2500,8 +2496,6 @@ public function testSemaphoreWithService()
25002496
self::assertTrue($container->hasDefinition('semaphore.default.factory'));
25012497
$storeDef = $container->getDefinition($container->getDefinition('semaphore.default.factory')->getArgument(0));
25022498
self::assertEquals(new Reference('my_service'), $storeDef->getArgument(0));
2503-
2504-
self::assertInstanceOf(SemaphoreFactory::class, $container->get('factory_public_alias'));
25052499
}
25062500

25072501
protected function createContainer(array $data = [])

0 commit comments

Comments
 (0)