Skip to content

Commit 8cadde1

Browse files
minor #61328 [FrameworkBundle] Decouple ControllerResolverTest from HttpKernel (nicolas-grekas)
This PR was merged into the 7.4 branch. Discussion ---------- [FrameworkBundle] Decouple ControllerResolverTest from HttpKernel | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Using non-public API for cross-components test case dependencies complicates maintenance. Commits ------- 4e9c9c16cfa [FrameworkBundle] Decouple ControllerResolverTest from HttpKernel
1 parent d19b87b commit 8cadde1

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

Tests/Controller/ControllerResolverTest.php

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@
1111

1212
namespace Symfony\Bundle\FrameworkBundle\Tests\Controller;
1313

14+
use PHPUnit\Framework\TestCase;
1415
use Psr\Container\ContainerInterface as Psr11ContainerInterface;
1516
use Psr\Log\LoggerInterface;
1617
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
1718
use Symfony\Bundle\FrameworkBundle\Controller\ControllerResolver;
1819
use Symfony\Component\DependencyInjection\Container;
1920
use Symfony\Component\HttpFoundation\Request;
20-
use Symfony\Component\HttpKernel\Tests\Controller\ContainerControllerResolverTest;
2121

22-
class ControllerResolverTest extends ContainerControllerResolverTest
22+
class ControllerResolverTest extends TestCase
2323
{
2424
public function testAbstractControllerGetsContainerWhenNotSet()
2525
{
@@ -111,11 +111,6 @@ protected function createControllerResolver(?LoggerInterface $logger = null, ?Ps
111111

112112
return new ControllerResolver($container, $logger);
113113
}
114-
115-
protected function createMockParser()
116-
{
117-
return $this->createMock(ControllerNameParser::class);
118-
}
119114
}
120115

121116
class DummyController extends AbstractController

0 commit comments

Comments
 (0)