Merge branch '5.4' into 6.0

* 5.4: (26 commits)
  [Dotenv] Fix testBootEnv() to start from a fresh context
  fix tests
  relax expected exception message for forward-compatibility with 5.4
  fix expected exception messages after changes made in Definition class
  [DependencyInjection] show class name on DI errors
  skip command completion tests with older Symfony Console versions
  Use GitHub issue form templates
  Fix CS
  add ResponseIsUnprocessable
  Add missing translations for Persian (fa)
  skip command completion tests with older Symfony Console versions
  prevent issues with timezones and DST by using only UNIX timestamps
  Add the missing translations for Bahasa Indonesia (id)
  [Finder] Fix .gitignore infinite loop
  Update README.md
  fix messenger DI dependency for registerAttributeForAutoconfiguration
  [Messenger] Autoconfigurable attributes
  Fix deprecations on PHP 8.2
  [Dotenv] Fix testLoadEnv() .env.dist isolation
  Since 5.0, throws \UnexpectedValueException has been removed.
  ...

Author: nicolas-grekas

Command/ConfigDumpReferenceCommand.php

@@ -15,6 +15,8 @@
 use Symfony\Component\Config\Definition\Dumper\XmlReferenceDumper;
 use Symfony\Component\Config\Definition\Dumper\YamlReferenceDumper;
 use Symfony\Component\Console\Attribute\AsCommand;
+use Symfony\Component\Console\Completion\CompletionInput;
+use Symfony\Component\Console\Completion\CompletionSuggestions;
 use Symfony\Component\Console\Exception\InvalidArgumentException;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
@@ -155,4 +157,32 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 
         return 0;
     }
+
+    public function complete(CompletionInput $input, CompletionSuggestions $suggestions): void
+    {
+        if ($input->mustSuggestArgumentValuesFor('name')) {
+            $suggestions->suggestValues($this->getAvailableBundles());
+        }
+
+        if ($input->mustSuggestOptionValuesFor('format')) {
+            $suggestions->suggestValues($this->getAvailableFormatOptions());
+        }
+    }
+
+    private function getAvailableBundles(): array
+    {
+        $bundles = [];
+
+        foreach ($this->getApplication()->getKernel()->getBundles() as $bundle) {
+            $bundles[] = $bundle->getName();
+            $bundles[] = $bundle->getContainerExtension()->getAlias();
+        }
+
+        return $bundles;
+    }
+
+    private function getAvailableFormatOptions(): array
+    {
+        return ['yaml', 'xml'];
+    }
 }

DependencyInjection/FrameworkExtension.php

@@ -96,6 +96,7 @@
 use Symfony\Component\Mailer\Bridge\Sendinblue\Transport\SendinblueTransportFactory;
 use Symfony\Component\Mailer\Mailer;
 use Symfony\Component\Mercure\HubRegistry;
+use Symfony\Component\Messenger\Attribute\AsMessageHandler;
 use Symfony\Component\Messenger\Bridge\AmazonSqs\Transport\AmazonSqsTransportFactory;
 use Symfony\Component\Messenger\Bridge\Amqp\Transport\AmqpTransportFactory;
 use Symfony\Component\Messenger\Bridge\Beanstalkd\Transport\BeanstalkdTransportFactory;
@@ -581,6 +582,13 @@ public function load(array $configs, ContainerBuilder $container)
         $container->registerAttributeForAutoconfiguration(AsController::class, static function (ChildDefinition $definition, AsController $attribute): void {
             $definition->addTag('controller.service_arguments');
         });
+        $container->registerAttributeForAutoconfiguration(AsMessageHandler::class, static function (ChildDefinition $definition, AsMessageHandler $attribute): void {
+            $tagAttributes = get_object_vars($attribute);
+            $tagAttributes['from_transport'] = $tagAttributes['fromTransport'];
+            unset($tagAttributes['fromTransport']);
+
+            $definition->addTag('messenger.message_handler', $tagAttributes);
+        });
 
         if (!$container->getParameter('kernel.debug')) {
             // remove tagged iterator argument for resource checkers

Resources/config/console.php

@@ -307,7 +307,7 @@
         ->set('console.command.secrets_list', SecretsListCommand::class)
             ->args([
                 service('secrets.vault'),
-                service('secrets.local_vault'),
+                service('secrets.local_vault')->ignoreOnInvalid(),
             ])
             ->tag('console.command')
 
@@ -321,7 +321,7 @@
         ->set('console.command.secrets_encrypt_from_local', SecretsEncryptFromLocalCommand::class)
             ->args([
                 service('secrets.vault'),
-                service('secrets.local_vault'),
+                service('secrets.local_vault')->ignoreOnInvalid(),
             ])
             ->tag('console.command')
     ;

Test/BrowserKitAssertionsTrait.php

@@ -94,6 +94,11 @@ public static function assertResponseCookieValueSame(string $name, string $expec
         ), $message);
     }
 
+    public static function assertResponseIsUnprocessable(string $message = ''): void
+    {
+        self::assertThatForResponse(new ResponseConstraint\ResponseIsUnprocessable(), $message);
+    }
+
     public static function assertBrowserHasCookie(string $name, string $path = '/', string $domain = null, string $message = ''): void
     {
         self::assertThatForClient(new BrowserKitConstraint\BrowserHasCookie($name, $path, $domain), $message);

Tests/DependencyInjection/PhpFrameworkExtensionTest.php

@@ -126,7 +126,7 @@ public function testRateLimiterLockFactory()
         });
 
         $this->expectException(OutOfBoundsException::class);
-        $this->expectExceptionMessage('The argument "2" doesn\'t exist.');
+        $this->expectExceptionMessageMatches('/^The argument "2" doesn\'t exist.*\.$/');
 
         $container->getDefinition('limiter.without_lock')->getArgument(2);
     }

Tests/Functional/ConfigDumpReferenceCommandTest.php

@@ -11,9 +11,11 @@
 
 namespace Symfony\Bundle\FrameworkBundle\Tests\Functional;
 
+use Symfony\Bundle\FrameworkBundle\Command\ConfigDumpReferenceCommand;
 use Symfony\Bundle\FrameworkBundle\Console\Application;
 use Symfony\Component\Console\Input\ArrayInput;
 use Symfony\Component\Console\Output\NullOutput;
+use Symfony\Component\Console\Tester\CommandCompletionTester;
 use Symfony\Component\Console\Tester\CommandTester;
 
 /**
@@ -81,6 +83,23 @@ public function testDumpAtPathXml()
         $this->assertStringContainsString('[ERROR] The "path" option is only available for the "yaml" format.', $tester->getDisplay());
     }
 
+    /**
+     * @dataProvider provideCompletionSuggestions
+     */
+    public function testComplete(array $input, array $expectedSuggestions)
+    {
+        $this->application->add(new ConfigDumpReferenceCommand());
+        $tester = new CommandCompletionTester($this->application->get('config:dump-reference'));
+        $suggestions = $tester->complete($input, 2);
+        $this->assertSame($expectedSuggestions, $suggestions);
+    }
+
+    public function provideCompletionSuggestions(): iterable
+    {
+        yield 'name' => [[''], ['DefaultConfigTestBundle', 'default_config_test', 'ExtensionWithoutConfigTestBundle', 'extension_without_config_test', 'FrameworkBundle', 'framework', 'TestBundle', 'test']];
+        yield 'option --format' => [['--format', ''], ['yaml', 'xml']];
+    }
+
     private function createCommandTester(): CommandTester
     {
         $command = $this->application->find('config:dump-reference');