Clarify goals of AbstractController

Author: fabpot

CHANGELOG.md

@@ -7,6 +7,7 @@ CHANGELOG
  * Add autowiring alias for `HttpCache\StoreInterface`
  * Deprecate the `AdapterInterface` autowiring alias, use `CacheItemPoolInterface` instead
  * Deprecate the public `profiler` service to private
+ * Deprecate `getDoctrine()` and `dispatchMessage()` in `AbstractController`, use method/constructor injection instead
 
 5.3
 ---

Controller/AbstractController.php

@@ -50,7 +50,7 @@
 use Twig\Environment;
 
 /**
- * Provides common features needed in controllers.
+ * Provides shortcuts for HTTP-related features in controllers.
  *
  * @author Fabien Potencier <[email protected]>
  */
@@ -370,9 +370,13 @@ protected function createFormBuilder($data = null, array $options = []): FormBui
      * Shortcut to return the Doctrine Registry service.
      *
      * @throws \LogicException If DoctrineBundle is not available
+     *
+     * @deprecated since 5.4, inject an instance of ManagerRegistry in your controller instead
      */
     protected function getDoctrine(): ManagerRegistry
     {
+        trigger_deprecation('symfony/framework-bundle', '5.4', 'Method "%s()" is deprecated, inject an instance of ManagerRegistry in your controller instead.', __METHOD__);
+
         if (!$this->container->has('doctrine')) {
             throw new \LogicException('The DoctrineBundle is not registered in your application. Try running "composer require symfony/orm-pack".');
         }
@@ -426,9 +430,13 @@ protected function isCsrfTokenValid(string $id, ?string $token): bool
      * Dispatches a message to the bus.
      *
      * @param object|Envelope $message The message or the message pre-wrapped in an envelope
+     *
+     * @deprecated since 5.4, inject an instance of MessageBusInterface in your controller instead
      */
     protected function dispatchMessage(object $message, array $stamps = []): Envelope
     {
+        trigger_deprecation('symfony/framework-bundle', '5.4', 'Method "%s()" is deprecated, inject an instance of MessageBusInterface in your controller instead.', __METHOD__);
+
         if (!$this->container->has('messenger.default_bus')) {
             $message = class_exists(Envelope::class) ? 'You need to define the "messenger.default_bus" configuration option.' : 'Try running "composer require symfony/messenger".';
             throw new \LogicException('The message bus is not enabled in your application. '.$message);