Fix dumping extension config without bundle

Author: yceruto

Command/AbstractConfigCommand.php

@@ -16,6 +16,7 @@
 use Symfony\Component\Console\Helper\Table;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\StyleInterface;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Extension\ExtensionInterface;
 
 /**
@@ -59,7 +60,7 @@ protected function listBundles($output)
     /**
      * @return ExtensionInterface
      */
-    protected function findExtension($name)
+    protected function findExtension($name, ContainerBuilder $container)
     {
         $bundles = $this->initializeBundles();
         $minScore = \INF;
@@ -79,20 +80,18 @@ protected function findExtension($name)
                 $guess = $bundle->getName();
                 $minScore = $distance;
             }
+        }
 
-            $extension = $bundle->getContainerExtension();
-
-            if ($extension) {
-                if ($name === $extension->getAlias()) {
-                    return $extension;
-                }
+        if ($container->hasExtension($name)) {
+            return $container->getExtension($name);
+        }
 
-                $distance = levenshtein($name, $extension->getAlias());
+        foreach ($container->getExtensions() as $extension) {
+            $distance = levenshtein($name, $extension->getAlias());
 
-                if ($distance < $minScore) {
-                    $guess = $extension->getAlias();
-                    $minScore = $distance;
-                }
+            if ($distance < $minScore) {
+                $guess = $extension->getAlias();
+                $minScore = $distance;
             }
         }
 

Command/ConfigDebugCommand.php

@@ -79,9 +79,9 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             return 0;
         }
 
-        $extension = $this->findExtension($name);
-        $extensionAlias = $extension->getAlias();
         $container = $this->compileContainer();
+        $extension = $this->findExtension($name, $container);
+        $extensionAlias = $extension->getAlias();
 
         $config = $container->resolveEnvPlaceholders(
             $container->getParameterBag()->resolveValue(

Command/ConfigDumpReferenceCommand.php

@@ -89,9 +89,10 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             return 0;
         }
 
-        $extension = $this->findExtension($name);
+        $container = $this->getContainerBuilder();
+        $extension = $this->findExtension($name, $container);
 
-        $configuration = $extension->getConfiguration([], $this->getContainerBuilder());
+        $configuration = $extension->getConfiguration([], $container);
 
         $this->validateConfiguration($extension, $configuration);
 

Tests/Functional/ConfigDebugCommandTest.php

@@ -68,6 +68,15 @@ public function testDefaultParameterValueIsResolvedIfConfigIsExisting()
         $this->assertStringContainsString(sprintf("dsn: 'file:%s/profiler'", $kernelCacheDir), $tester->getDisplay());
     }
 
+    public function testDumpExtensionConfigWithoutBundle()
+    {
+        $tester = $this->createCommandTester();
+        $ret = $tester->execute(['name' => 'test_dump']);
+
+        $this->assertSame(0, $ret, 'Returns 0 in case of success');
+        $this->assertStringContainsString('enabled: true', $tester->getDisplay());
+    }
+
     public function testDumpUndefinedBundleOption()
     {
         $tester = $this->createCommandTester();

Tests/Functional/ConfigDumpReferenceCommandTest.php

@@ -40,6 +40,15 @@ public function testDumpBundleName()
         $this->assertStringContainsString('    custom:', $tester->getDisplay());
     }
 
+    public function testDumpExtensionConfigWithoutBundle()
+    {
+        $tester = $this->createCommandTester();
+        $ret = $tester->execute(['name' => 'test_dump']);
+
+        $this->assertSame(0, $ret, 'Returns 0 in case of success');
+        $this->assertStringContainsString('enabled:              true', $tester->getDisplay());
+    }
+
     public function testDumpAtPath()
     {
         $tester = $this->createCommandTester();

Tests/Functional/Extension/TestDumpExtension.php

@@ -0,0 +1,41 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Bundle\FrameworkBundle\Tests\Functional\Extension;
+
+use Symfony\Component\Config\Definition\Builder\TreeBuilder;
+use Symfony\Component\Config\Definition\ConfigurationInterface;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Extension\Extension;
+
+class TestDumpExtension extends Extension implements ConfigurationInterface
+{
+    public function getConfigTreeBuilder()
+    {
+        $treeBuilder = new TreeBuilder('test_dump');
+        $treeBuilder->getRootNode()
+            ->children()
+                ->booleanNode('enabled')->defaultTrue()->end()
+            ->end()
+        ;
+
+        return $treeBuilder;
+    }
+
+    public function load(array $configs, ContainerBuilder $container)
+    {
+    }
+
+    public function getConfiguration(array $config, ContainerBuilder $container)
+    {
+        return $this;
+    }
+}

Tests/Functional/app/AppKernel.php

@@ -12,6 +12,7 @@
 namespace Symfony\Bundle\FrameworkBundle\Tests\Functional\app;
 
 use Psr\Log\NullLogger;
+use Symfony\Bundle\FrameworkBundle\Tests\Functional\Extension\TestDumpExtension;
 use Symfony\Component\Config\Loader\LoaderInterface;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\ContainerInterface;
@@ -78,6 +79,7 @@ public function registerContainerConfiguration(LoaderInterface $loader)
     protected function build(ContainerBuilder $container)
     {
         $container->register('logger', NullLogger::class);
+        $container->registerExtension(new TestDumpExtension());
     }
 
     public function __sleep(): array