Skip to content

Commit d5bf8a8

Browse files
author
Robin Chalas
committed
Merge branch '4.1'
* 4.1: [FrameworkBundle] Don't register MessengerDataCollector if messenger is not enabled [Validator] Add Japanese translations [Console] Fix input values allowed types
2 parents 2b68b19 + f08a1c9 commit d5bf8a8

File tree

3 files changed

+20
-5
lines changed

3 files changed

+20
-5
lines changed

DependencyInjection/FrameworkExtension.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ class FrameworkExtension extends Extension
118118
private $sessionConfigEnabled = false;
119119
private $annotationsConfigEnabled = false;
120120
private $validatorConfigEnabled = false;
121+
private $messengerConfigEnabled = false;
121122

122123
/**
123124
* Responds to the app.config configuration parameter.
@@ -279,7 +280,7 @@ public function load(array $configs, ContainerBuilder $container)
279280
$this->registerLockConfiguration($config['lock'], $container, $loader);
280281
}
281282

282-
if ($this->isConfigEnabled($container, $config['messenger'])) {
283+
if ($this->messengerConfigEnabled = $this->isConfigEnabled($container, $config['messenger'])) {
283284
$this->registerMessengerConfiguration($config['messenger'], $container, $loader, $config['serializer'], $config['validation']);
284285
} else {
285286
$container->removeDefinition('console.command.messenger_consume_messages');
@@ -466,6 +467,10 @@ private function registerProfilerConfiguration(array $config, ContainerBuilder $
466467
$container->getDefinition('translator.data_collector')->setDecoratedService('translator');
467468
}
468469

470+
if ($this->messengerConfigEnabled) {
471+
$loader->load('messenger_debug.xml');
472+
}
473+
469474
$container->setParameter('profiler_listener.only_exceptions', $config['only_exceptions']);
470475
$container->setParameter('profiler_listener.only_master_requests', $config['only_master_requests']);
471476

Resources/config/collectors.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,5 @@
5252
<tag name="kernel.event_listener" event="kernel.controller" method="onKernelController"/>
5353
<tag name="data_collector" template="@WebProfiler/Collector/router.html.twig" id="router" priority="285" />
5454
</service>
55-
56-
<service id="data_collector.messenger" class="Symfony\Component\Messenger\DataCollector\MessengerDataCollector">
57-
<tag name="data_collector" template="@WebProfiler/Collector/messenger.html.twig" id="messenger" priority="100" />
58-
</service>
5955
</services>
6056
</container>

Resources/config/messenger_debug.xml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
<?xml version="1.0" ?>
2+
3+
<container xmlns="http://symfony.com/schema/dic/services"
4+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
5+
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
6+
7+
<services>
8+
<defaults public="false" />
9+
10+
<service id="data_collector.messenger" class="Symfony\Component\Messenger\DataCollector\MessengerDataCollector">
11+
<tag name="data_collector" template="@WebProfiler/Collector/messenger.html.twig" id="messenger" priority="100" />
12+
</service>
13+
</services>
14+
</container>

0 commit comments

Comments
 (0)