Skip to content

Commit eac054a

Browse files
committed
feature #42123 [Notifier] Add FakeSMS Logger transport (noniagriconomie)
This PR was merged into the 5.4 branch. Discussion ---------- [Notifier] Add FakeSMS Logger transport | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Sub part of #40625 | License | MIT | Doc PR | WIP Friendly ping `@OskarStark` As commented [here](symfony/symfony#40625 (comment)) I use mainly the sms transport, thus wanted to work on the fake sms. This PR adds the `logger`. For the part `an optional channel`, how can we get to here? dymanically retreiving the proper logger based on the dsn config? Commits ------- 2596a724e4 Add FakeSMS Logger transport
2 parents 610362b + 0e5b540 commit eac054a

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

DependencyInjection/FrameworkExtension.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2506,7 +2506,8 @@ private function registerNotifierConfiguration(array $config, ContainerBuilder $
25062506

25072507
if (ContainerBuilder::willBeAvailable('symfony/fake-sms-notifier', FakeSmsTransportFactory::class, ['symfony/framework-bundle', 'symfony/notifier', 'symfony/mailer'])) {
25082508
$container->getDefinition($classToServices[FakeSmsTransportFactory::class])
2509-
->replaceArgument('$mailer', new Reference('mailer'));
2509+
->replaceArgument('$mailer', new Reference('mailer'))
2510+
->replaceArgument('$logger', new Reference('logger'));
25102511
}
25112512

25122513
if (isset($config['admin_recipients'])) {

0 commit comments

Comments
 (0)