minor #42490 More return type fixes (bis) (nicolas-grekas)

This PR was merged into the 5.4 branch.

Discussion
----------

More return type fixes (bis)

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

c6a20b4e4d More return type fixes (bis)

Author: nicolas-grekas

CacheWarmer/AbstractPhpFileCacheWarmer.php

@@ -49,7 +49,7 @@ public function warmUp(string $cacheDir)
         spl_autoload_register([ClassExistenceResource::class, 'throwOnRequiredClass']);
         try {
             if (!$this->doWarmUp($cacheDir, $arrayAdapter)) {
-                return;
+                return [];
             }
         } finally {
             spl_autoload_unregister([ClassExistenceResource::class, 'throwOnRequiredClass']);

Tests/CacheWarmer/RouterCacheWarmerTest.php

@@ -28,7 +28,7 @@ public function testWarmUpWithWarmebleInterface()
         $routerCacheWarmer = new RouterCacheWarmer($containerMock);
 
         $routerCacheWarmer->warmUp('/tmp');
-        $routerMock->expects($this->any())->method('warmUp')->with('/tmp')->willReturn('');
+        $routerMock->expects($this->any())->method('warmUp')->with('/tmp')->willReturn([]);
         $this->addToAssertionCount(1);
     }
 

Translation/Translator.php

@@ -100,7 +100,7 @@ public function warmUp(string $cacheDir)
     {
         // skip warmUp when translator doesn't use cache
         if (null === $this->options['cache_dir']) {
-            return;
+            return [];
         }
 
         $localesToWarmUp = $this->enabledLocales ?: array_merge($this->getFallbackLocales(), [$this->getLocale()], $this->resourceLocales);