Deprecate configuring tag names and service ids in compiler passes

nicolas-grekas · nicolas-grekas · commit 470b749204ea · 2021-03-15T19:33:21.000+01:00
diff --git a/DependencyInjection/HttpClientPass.php b/DependencyInjection/HttpClientPass.php
@@ -23,6 +23,10 @@ final class HttpClientPass implements CompilerPassInterface
 
     public function __construct(string $clientTag = 'http_client.client')
     {
+        if (0 < \func_num_args()) {
+            trigger_deprecation('symfony/http-client', '5.3', 'Configuring "%s" is deprecated.', __CLASS__);
+        }
+
         $this->clientTag = $clientTag;
     }
 
diff --git a/composer.json b/composer.json
@@ -23,6 +23,7 @@
     "require": {
         "php": ">=7.2.5",
         "psr/log": "^1.0",
+        "symfony/deprecation-contracts": "^2.1",
         "symfony/http-client-contracts": "^2.4",
         "symfony/polyfill-php73": "^1.11",
         "symfony/polyfill-php80": "^1.15",

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,10 @@ final class HttpClientPass implements CompilerPassInterface`
`23`	`23`
`24`	`24`	`public function __construct(string $clientTag = 'http_client.client')`
`25`	`25`	`{`
	`26`	`+ if (0 < \func_num_args()) {`
	`27`	`+ trigger_deprecation('symfony/http-client', '5.3', 'Configuring "%s" is deprecated.', __CLASS__);`
	`28`	`+ }`
	`29`	`+`
`26`	`30`	`$this->clientTag = $clientTag;`
`27`	`31`	`}`
`28`	`32`