Skip to content

Commit 50c1c09

Browse files
fancywebnicolas-grekas
authored andcommitted
Fix some \Throwable support remaining issues
1 parent e83bad5 commit 50c1c09

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

DataCollector/HttpClientDataCollector.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,10 @@ public function registerClient(string $name, TraceableHttpClient $client)
3333

3434
/**
3535
* {@inheritdoc}
36+
*
37+
* @param \Throwable|null $exception
3638
*/
37-
public function collect(Request $request, Response $response, \Exception $exception = null)
39+
public function collect(Request $request, Response $response/*, \Throwable $exception = null*/)
3840
{
3941
$this->initData();
4042

composer.json

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,12 @@
3131
"php-http/httplug": "^1.0|^2.0",
3232
"psr/http-client": "^1.0",
3333
"symfony/dependency-injection": "^4.3|^5.0",
34-
"symfony/http-kernel": "^4.3",
34+
"symfony/http-kernel": "^4.4",
3535
"symfony/process": "^4.2|^5.0",
36-
"symfony/service-contracts": "^1.0|^2",
37-
"symfony/var-dumper": "^4.3|^5.0"
36+
"symfony/service-contracts": "^1.0|^2"
37+
},
38+
"conflict": {
39+
"symfony/http-kernel": "<4.4"
3840
},
3941
"autoload": {
4042
"psr-4": { "Symfony\\Component\\HttpClient\\": "" },

0 commit comments

Comments
 (0)