Merge branch '4.4'

* 4.4: (28 commits)
  [FrameworkBundle] Fix framework bundle lock configuration not working as expected
  [Validator] Add the missing translations for the Azerbaijani locale
  [HttpClient] workaround bad Content-Length sent by old libcurl
  [Cache] dont override native Memcached options
  Fix CS
  Fix exceptions (PDOException) error code type
  [ErrorHandler] fix return-type patching logic
  [Messenger] Added support for `from_transport` attribute on `messenger.message_handler` tag
  [ErrorHandler] don't throw deprecations for return-types by default
  ensure legacy event dispatcher compatibility
  ensure legacy event dispatcher compatibility
  Fix return type of Process::restart().
  [Cache] fail gracefully when locking is not supported
  [HttpKernel] compress files generated by the profiler
  tweak deprecation messages and changelog
  fix version in @deprecated annotation
  Use VarCloner data instead of legacy array for query params
  [Security] use LegacyEventDispatcherProxy
  [HttpClient] fix undefined index access
  [HttpClient] fix race condition when reading response with informational status
  ...

Author: nicolas-grekas

CurlHttpClient.php

@@ -269,7 +269,7 @@ public function request(string $method, string $url, array $options = []): Respo
             if ('POST' !== $method) {
                 $curlopts[CURLOPT_UPLOAD] = true;
             }
-        } elseif ('' !== $body) {
+        } elseif ('' !== $body || 'POST' === $method) {
             $curlopts[CURLOPT_POSTFIELDS] = $body;
         }
 
@@ -383,7 +383,7 @@ private static function handlePush($parent, $pushed, array $requestHeaders, Curl
      */
     private static function acceptPushForRequest(string $method, array $options, PushedResponse $pushedResponse): bool
     {
-        if ($options['body'] || $method !== $pushedResponse->requestHeaders[':method'][0]) {
+        if ('' !== $options['body'] || $method !== $pushedResponse->requestHeaders[':method'][0]) {
             return false;
         }
 

DataCollector/HttpClientDataCollector.php

@@ -113,7 +113,7 @@ private function collectOnClient(TraceableHttpClient $client): array
             }
 
             $info = $trace['info'];
-            $traces[$i]['http_code'] = $info['http_code'];
+            $traces[$i]['http_code'] = $info['http_code'] ?? 0;
 
             unset($info['filetime'], $info['http_code'], $info['ssl_verify_result'], $info['content_type']);
 

Response/CurlResponse.php

@@ -133,15 +133,17 @@ public function __construct(CurlClientState $multi, $ch, array $options = null,
 
             if (\in_array($waitFor, ['headers', 'destruct'], true)) {
                 try {
-                    self::stream([$response])->current();
+                    foreach (self::stream([$response]) as $chunk) {
+                        if ($chunk->isFirst()) {
+                            break;
+                        }
+                    }
                 } catch (\Throwable $e) {
                     // Persist timeouts thrown during initialization
                     $response->info['error'] = $e->getMessage();
                     $response->close();
                     throw $e;
                 }
-            } elseif ('content' === $waitFor && ($response->multi->handlesActivity[$response->id][0] ?? null) instanceof FirstChunk) {
-                self::stream([$response])->current();
             }
 
             curl_setopt($ch, CURLOPT_HEADERFUNCTION, null);

Response/NativeResponse.php

@@ -67,7 +67,11 @@ public function __construct(NativeClientState $multi, $context, string $url, $op
             }
 
             if (null === $response->remaining) {
-                self::stream([$response])->current();
+                foreach (self::stream([$response]) as $chunk) {
+                    if ($chunk->isFirst()) {
+                        break;
+                    }
+                }
             }
         };
     }