Merge branch '5.4' into 6.0

* 5.4:
  [Console] Restore psr/log >= 3.0 conflict
  [Security] Make the abstract Voter class implement CacheableVoterInterface
  Add generic types to traversable implementations
  [Security] Fix TypeError message
  [Security] Fix deprecation layer
  [FrameworkBundle] Add completion for workflow:dump
  Fix cancel button
  Fix misleading error on missing provider with authenticator manager
  Don't limit retries of toolbar loading

Author: derrabus

HttplugClient.php

@@ -60,7 +60,12 @@ final class HttplugClient implements HttplugInterface, HttpAsyncClient, RequestF
     private HttpClientInterface $client;
     private ResponseFactoryInterface $responseFactory;
     private StreamFactoryInterface $streamFactory;
+
+    /**
+     * @var \SplObjectStorage<ResponseInterface, array{RequestInterface, Promise}>|null
+     */
     private ?\SplObjectStorage $promisePool;
+
     private HttplugWaitLoop $waitLoop;
 
     public function __construct(HttpClientInterface $client = null, ResponseFactoryInterface $responseFactory = null, StreamFactoryInterface $streamFactory = null)

Internal/HttplugWaitLoop.php

@@ -12,6 +12,8 @@
 namespace Symfony\Component\HttpClient\Internal;
 
 use Http\Client\Exception\NetworkException;
+use Http\Promise\Promise;
+use Psr\Http\Message\RequestInterface as Psr7RequestInterface;
 use Psr\Http\Message\ResponseFactoryInterface;
 use Psr\Http\Message\ResponseInterface as Psr7ResponseInterface;
 use Psr\Http\Message\StreamFactoryInterface;
@@ -33,6 +35,9 @@ final class HttplugWaitLoop
     private ResponseFactoryInterface $responseFactory;
     private StreamFactoryInterface $streamFactory;
 
+    /**
+     * @param \SplObjectStorage<ResponseInterface, array{Psr7RequestInterface, Promise}>|null $promisePool
+     */
     public function __construct(HttpClientInterface $client, ?\SplObjectStorage $promisePool, ResponseFactoryInterface $responseFactory, StreamFactoryInterface $streamFactory)
     {
         $this->client = $client;

Response/AsyncResponse.php

@@ -311,6 +311,9 @@ public static function stream(iterable $responses, float $timeout = null, string
         }
     }
 
+    /**
+     * @param \SplObjectStorage<ResponseInterface, AsyncResponse>|null $asyncMap
+     */
     private static function passthru(HttpClientInterface $client, self $r, ChunkInterface $chunk, \SplObjectStorage $asyncMap = null): \Generator
     {
         $r->stream = null;
@@ -332,6 +335,9 @@ private static function passthru(HttpClientInterface $client, self $r, ChunkInte
         yield from self::passthruStream($response, $r, null, $asyncMap);
     }
 
+    /**
+     * @param \SplObjectStorage<ResponseInterface, AsyncResponse>|null $asyncMap
+     */
     private static function passthruStream(ResponseInterface $response, self $r, ?ChunkInterface $chunk, ?\SplObjectStorage $asyncMap): \Generator
     {
         while (true) {

Response/TransportResponseTrait.php

@@ -148,6 +148,8 @@ private function doDestruct()
     /**
      * Implements an event loop based on a buffer activity queue.
      *
+     * @param iterable<array-key, self> $responses
+     *
      * @internal
      */
     public static function stream(iterable $responses, float $timeout = null): \Generator