Skip to content

Commit 6486e77

Browse files
committed
[VarDumper] Added unique id for every single dump in html
1 parent 5d8e79a commit 6486e77

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

Tests/DataCollector/DumpDataCollectorTest.php

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,18 +32,21 @@ public function testDump()
3232
$collector->dump($data); $line = __LINE__;
3333
$this->assertSame(1, $collector->getDumpsCount());
3434

35+
$dump = $collector->getDumps('html');
36+
$this->assertTrue(isset($dump[0]['data']));
37+
$dump[0]['data'] = preg_replace('/^.*?<pre/', '<pre', $dump[0]['data']);
38+
preg_match('/sf-dump-(\\d{2,})/', $dump[0]['data'], $matches);
39+
$dumpId = $matches[1];
40+
3541
$xDump = array(
3642
array(
37-
'data' => "<pre id=sf-dump><span class=sf-dump-0><span class=sf-dump-num>123</span>\n</span></pre><script>Sfjs.dump.instrument()</script>\n",
38-
'name' => 'DumpDataCollectorTest.php',
39-
'file' => __FILE__,
40-
'line' => $line,
41-
'fileExcerpt' => false,
43+
'data' => "<pre id=sf-dump-{$dumpId}><span class=sf-dump-0><span class=sf-dump-num>123</span>\n</span></pre><script>Sfjs.dump.instrument()</script>\n",
44+
'name' => 'DumpDataCollectorTest.php',
45+
'file' => __FILE__,
46+
'line' => $line,
47+
'fileExcerpt' => false,
4248
),
4349
);
44-
$dump = $collector->getDumps('html');
45-
$this->assertTrue(isset($dump[0]['data']));
46-
$dump[0]['data'] = preg_replace('/^.*?<pre/', '<pre', $dump[0]['data']);
4750
$this->assertSame($xDump, $dump);
4851

4952
$this->assertStringStartsWith(

0 commit comments

Comments
 (0)