minor #18296 [3.1] fix testing deprecation messages (xabbuh)

This PR was merged into the 3.1-dev branch.

Discussion
----------

[3.1] fix testing deprecation messages

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

* always restore the previous error handler
* throw `LogicExcetion` when unexpected error type is triggered

Commits
-------

0df544f fix testing deprecation messages

Author: fabpot

Tests/Fragment/EsiFragmentRendererTest.php

@@ -32,9 +32,13 @@ public function testRenderFallbackWithObjectAttributesIsDeprecated()
     {
         $deprecations = array();
         set_error_handler(function ($type, $message) use (&$deprecations) {
-            if (E_USER_DEPRECATED === $type) {
-                $deprecations[] = $message;
+            if (E_USER_DEPRECATED !== $type) {
+                restore_error_handler();
+
+                return call_user_func_array('PHPUnit_Util_ErrorHandler::handleError', func_get_args());
             }
+
+            $deprecations[] = $message;
         });
 
         $strategy = new EsiFragmentRenderer(new Esi(), $this->getInlineStrategy(true), new UriSigner('foo'));
@@ -45,10 +49,10 @@ public function testRenderFallbackWithObjectAttributesIsDeprecated()
 
         $strategy->render($reference, $request);
 
+        restore_error_handler();
+
         $this->assertCount(1, $deprecations);
         $this->assertContains('Passing objects as part of URI attributes to the ESI and SSI rendering strategies is deprecated', $deprecations[0]);
-
-        restore_error_handler();
     }
 
     public function testRender()