Static code analysis with Php Inspections (EA Extended): dead code dropped, couple bugs fixed

kalessil · kalessil · commit 96695eb94e26 · 2017-03-03T17:35:37.000+01:00
diff --git a/DateFormatter/DateFormat/TimeZoneTransformer.php b/DateFormatter/DateFormat/TimeZoneTransformer.php
@@ -94,6 +94,6 @@ public static function getEtcTimeZoneId($formattedTimeZone)
             return 'Etc/GMT'.($hours !== 0 ? $signal.$hours : '');
         }
 
-        throw new \InvalidArgumentException('The GMT time zone \'%s\' does not match with the supported formats GMT[+-]HH:MM or GMT[+-]HHMM.');
+        throw new \InvalidArgumentException(sprintf("The GMT time zone '%s' does not match with the supported formats GMT[+-]HH:MM or GMT[+-]HHMM.", $formattedTimeZone));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,6 @@ public static function getEtcTimeZoneId($formattedTimeZone)`
`94`	`94`	`return 'Etc/GMT'.($hours !== 0 ? $signal.$hours : '');`
`95`	`95`	`}`
`96`	`96`
`97`		`- throw new \InvalidArgumentException('The GMT time zone \'%s\' does not match with the supported formats GMT[+-]HH:MM or GMT[+-]HHMM.');`
	`97`	`+ throw new \InvalidArgumentException(sprintf("The GMT time zone '%s' does not match with the supported formats GMT[+-]HH:MM or GMT[+-]HHMM.", $formattedTimeZone));`
`98`	`98`	`}`
`99`	`99`	`}`