Migrate to static data providers using rector/rector

OskarStark · nicolas-grekas · commit af0e32d9e452 · 2023-02-14T09:03:56.000+01:00
diff --git a/Tests/Collator/AbstractCollatorTest.php b/Tests/Collator/AbstractCollatorTest.php
@@ -31,7 +31,7 @@ public function testAsort($array, $sortFlag, $expected)
         $this->assertSame($expected, $array);
     }
 
-    public function asortProvider()
+    public static function asortProvider()
     {
         return [
             /* array, sortFlag, expected */
diff --git a/Tests/CurrenciesTest.php b/Tests/CurrenciesTest.php
@@ -674,7 +674,7 @@ public function testGetSymbol($displayLocale)
         }
     }
 
-    public function provideCurrencies()
+    public static function provideCurrencies()
     {
         return array_map(
             function ($currency) { return [$currency]; },
@@ -701,7 +701,7 @@ public function testGetRoundingIncrement($currency)
         $this->assertIsNumeric(Currencies::getRoundingIncrement($currency));
     }
 
-    public function provideCurrenciesWithNumericEquivalent()
+    public static function provideCurrenciesWithNumericEquivalent()
     {
         return array_map(
             function ($value) { return [$value]; },
@@ -717,7 +717,7 @@ public function testGetNumericCode($currency)
         $this->assertSame(self::ALPHA3_TO_NUMERIC[$currency], Currencies::getNumericCode($currency));
     }
 
-    public function provideCurrenciesWithoutNumericEquivalent()
+    public static function provideCurrenciesWithoutNumericEquivalent()
     {
         return array_map(
             function ($value) { return [$value]; },
@@ -734,7 +734,7 @@ public function testGetNumericCodeFailsIfNoNumericEquivalent($currency)
         Currencies::getNumericCode($currency);
     }
 
-    public function provideValidNumericCodes()
+    public static function provideValidNumericCodes()
     {
         $numericToAlpha3 = $this->getNumericToAlpha3Mapping();
 
@@ -759,7 +759,7 @@ public function testForNumericCode($numeric, $expected)
         $this->assertSame($expected, $actual);
     }
 
-    public function provideInvalidNumericCodes()
+    public static function provideInvalidNumericCodes()
     {
         $validNumericCodes = array_keys($this->getNumericToAlpha3Mapping());
         $invalidNumericCodes = array_diff(range(0, 1000), $validNumericCodes);
diff --git a/Tests/Data/Bundle/Reader/BundleEntryReaderTest.php b/Tests/Data/Bundle/Reader/BundleEntryReaderTest.php
@@ -165,7 +165,7 @@ public function testDontFallbackIfLocaleDoesNotExistAndFallbackDisabled()
         $this->reader->readEntry(self::RES_DIR, 'en_GB', ['Entries', 'Bam'], false);
     }
 
-    public function provideMergeableValues()
+    public static function provideMergeableValues()
     {
         return [
             ['foo', null, 'foo'],
diff --git a/Tests/Globals/AbstractIntlGlobalsTest.php b/Tests/Globals/AbstractIntlGlobalsTest.php
@@ -22,7 +22,7 @@
  */
 abstract class AbstractIntlGlobalsTest extends TestCase
 {
-    public function errorNameProvider()
+    public static function errorNameProvider()
     {
         return [
             [-129, '[BOGUS UErrorCode]'],
diff --git a/Tests/LanguagesTest.php b/Tests/LanguagesTest.php
@@ -1742,7 +1742,7 @@ public function testGetNameDefaultLocale()
         }
     }
 
-    public function provideLanguagesWithAlpha3Equivalent()
+    public static function provideLanguagesWithAlpha3Equivalent()
     {
         return array_map(
             function ($value) { return [$value]; },
@@ -1758,7 +1758,7 @@ public function testGetAlpha3Code($language)
         $this->assertSame(self::ALPHA2_TO_ALPHA3[$language], Languages::getAlpha3Code($language));
     }
 
-    public function provideLanguagesWithoutAlpha3Equivalent()
+    public static function provideLanguagesWithoutAlpha3Equivalent()
     {
         return array_map(
             function ($value) { return [$value]; },
@@ -1792,7 +1792,7 @@ public function testGetAlpha3Codes()
         $this->assertSame(self::ALPHA3_CODES, Languages::getAlpha3Codes());
     }
 
-    public function provideLanguagesWithAlpha2Equivalent()
+    public static function provideLanguagesWithAlpha2Equivalent()
     {
         return array_map(
             function ($value) { return [$value]; },
@@ -1808,7 +1808,7 @@ public function testGetAlpha2Code($language)
         $this->assertSame(self::ALPHA3_TO_ALPHA2[$language], Languages::getAlpha2Code($language));
     }
 
-    public function provideLanguagesWithoutAlpha2Equivalent()
+    public static function provideLanguagesWithoutAlpha2Equivalent()
     {
         return array_map(
             function ($value) { return [$value]; },
diff --git a/Tests/LocaleTest.php b/Tests/LocaleTest.php
@@ -16,7 +16,7 @@
 
 class LocaleTest extends TestCase
 {
-    public function provideGetFallbackTests()
+    public static function provideGetFallbackTests()
     {
         $tests = [
             ['sl_Latn_IT', 'sl_Latn_IT_nedis'],
diff --git a/Tests/TimezonesTest.php b/Tests/TimezonesTest.php
@@ -639,7 +639,7 @@ public function testGetCountryCodeAvailability(string $timezone)
         }
     }
 
-    public function provideTimezones(): iterable
+    public static function provideTimezones(): iterable
     {
         return array_map(function ($timezone) {
             return [$timezone];
@@ -657,7 +657,7 @@ public function testForCountryCodeAvailability(string $country)
         $this->addToAssertionCount(1);
     }
 
-    public function provideCountries(): iterable
+    public static function provideCountries(): iterable
     {
         return array_map(function ($country) {
             return [$country];
diff --git a/Tests/Util/IcuVersionTest.php b/Tests/Util/IcuVersionTest.php
@@ -19,7 +19,7 @@
  */
 class IcuVersionTest extends TestCase
 {
-    public function normalizeProvider()
+    public static function normalizeProvider()
     {
         return [
             [null, '1', '10'],
@@ -49,7 +49,7 @@ public function testNormalize($precision, $version, $result)
         $this->assertSame($result, IcuVersion::normalize($version, $precision));
     }
 
-    public function compareProvider()
+    public static function compareProvider()
     {
         return [
             [null, '1', '==', '1', true],
diff --git a/Tests/Util/VersionTest.php b/Tests/Util/VersionTest.php
@@ -19,7 +19,7 @@
  */
 class VersionTest extends TestCase
 {
-    public function normalizeProvider()
+    public static function normalizeProvider()
     {
         return [
             [null, '1', '1'],
@@ -53,7 +53,7 @@ public function testNormalize($precision, $version, $result)
         $this->assertSame($result, Version::normalize($version, $precision));
     }
 
-    public function compareProvider()
+    public static function compareProvider()
     {
         return [
             [null, '1', '==', '1', true],

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ public function testAsort($array, $sortFlag, $expected)`
`31`	`31`	`$this->assertSame($expected, $array);`
`32`	`32`	`}`
`33`	`33`
`34`		`- public function asortProvider()`
	`34`	`+ public static function asortProvider()`
`35`	`35`	`{`
`36`	`36`	`return [`
`37`	`37`	`/* array, sortFlag, expected */`
Original file line number	Diff line number	Diff line change
`@@ -674,7 +674,7 @@ public function testGetSymbol($displayLocale)`
`674`	`674`	`}`
`675`	`675`	`}`
`676`	`676`
`677`		`- public function provideCurrencies()`
	`677`	`+ public static function provideCurrencies()`
`678`	`678`	`{`
`679`	`679`	`return array_map(`
`680`	`680`	`function ($currency) { return [$currency]; },`
`@@ -701,7 +701,7 @@ public function testGetRoundingIncrement($currency)`
`701`	`701`	`$this->assertIsNumeric(Currencies::getRoundingIncrement($currency));`
`702`	`702`	`}`
`703`	`703`
`704`		`- public function provideCurrenciesWithNumericEquivalent()`
	`704`	`+ public static function provideCurrenciesWithNumericEquivalent()`
`705`	`705`	`{`
`706`	`706`	`return array_map(`
`707`	`707`	`function ($value) { return [$value]; },`
`@@ -717,7 +717,7 @@ public function testGetNumericCode($currency)`
`717`	`717`	`$this->assertSame(self::ALPHA3_TO_NUMERIC[$currency], Currencies::getNumericCode($currency));`
`718`	`718`	`}`
`719`	`719`
`720`		`- public function provideCurrenciesWithoutNumericEquivalent()`
	`720`	`+ public static function provideCurrenciesWithoutNumericEquivalent()`
`721`	`721`	`{`
`722`	`722`	`return array_map(`
`723`	`723`	`function ($value) { return [$value]; },`
`@@ -734,7 +734,7 @@ public function testGetNumericCodeFailsIfNoNumericEquivalent($currency)`
`734`	`734`	`Currencies::getNumericCode($currency);`
`735`	`735`	`}`
`736`	`736`
`737`		`- public function provideValidNumericCodes()`
	`737`	`+ public static function provideValidNumericCodes()`
`738`	`738`	`{`
`739`	`739`	`$numericToAlpha3 = $this->getNumericToAlpha3Mapping();`
`740`	`740`
`@@ -759,7 +759,7 @@ public function testForNumericCode($numeric, $expected)`
`759`	`759`	`$this->assertSame($expected, $actual);`
`760`	`760`	`}`
`761`	`761`
`762`		`- public function provideInvalidNumericCodes()`
	`762`	`+ public static function provideInvalidNumericCodes()`
`763`	`763`	`{`
`764`	`764`	`$validNumericCodes = array_keys($this->getNumericToAlpha3Mapping());`
`765`	`765`	`$invalidNumericCodes = array_diff(range(0, 1000), $validNumericCodes);`
Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,7 @@ public function testDontFallbackIfLocaleDoesNotExistAndFallbackDisabled()`
`165`	`165`	`$this->reader->readEntry(self::RES_DIR, 'en_GB', ['Entries', 'Bam'], false);`
`166`	`166`	`}`
`167`	`167`
`168`		`- public function provideMergeableValues()`
	`168`	`+ public static function provideMergeableValues()`
`169`	`169`	`{`
`170`	`170`	`return [`
`171`	`171`	`['foo', null, 'foo'],`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@`
`22`	`22`	`*/`
`23`	`23`	`abstract class AbstractIntlGlobalsTest extends TestCase`
`24`	`24`	`{`
`25`		`- public function errorNameProvider()`
	`25`	`+ public static function errorNameProvider()`
`26`	`26`	`{`
`27`	`27`	`return [`
`28`	`28`	`[-129, '[BOGUS UErrorCode]'],`
Original file line number	Diff line number	Diff line change
`@@ -1742,7 +1742,7 @@ public function testGetNameDefaultLocale()`
`1742`	`1742`	`}`
`1743`	`1743`	`}`
`1744`	`1744`
`1745`		`- public function provideLanguagesWithAlpha3Equivalent()`
	`1745`	`+ public static function provideLanguagesWithAlpha3Equivalent()`
`1746`	`1746`	`{`
`1747`	`1747`	`return array_map(`
`1748`	`1748`	`function ($value) { return [$value]; },`
`@@ -1758,7 +1758,7 @@ public function testGetAlpha3Code($language)`
`1758`	`1758`	`$this->assertSame(self::ALPHA2_TO_ALPHA3[$language], Languages::getAlpha3Code($language));`
`1759`	`1759`	`}`
`1760`	`1760`
`1761`		`- public function provideLanguagesWithoutAlpha3Equivalent()`
	`1761`	`+ public static function provideLanguagesWithoutAlpha3Equivalent()`
`1762`	`1762`	`{`
`1763`	`1763`	`return array_map(`
`1764`	`1764`	`function ($value) { return [$value]; },`
`@@ -1792,7 +1792,7 @@ public function testGetAlpha3Codes()`
`1792`	`1792`	`$this->assertSame(self::ALPHA3_CODES, Languages::getAlpha3Codes());`
`1793`	`1793`	`}`
`1794`	`1794`
`1795`		`- public function provideLanguagesWithAlpha2Equivalent()`
	`1795`	`+ public static function provideLanguagesWithAlpha2Equivalent()`
`1796`	`1796`	`{`
`1797`	`1797`	`return array_map(`
`1798`	`1798`	`function ($value) { return [$value]; },`
`@@ -1808,7 +1808,7 @@ public function testGetAlpha2Code($language)`
`1808`	`1808`	`$this->assertSame(self::ALPHA3_TO_ALPHA2[$language], Languages::getAlpha2Code($language));`
`1809`	`1809`	`}`
`1810`	`1810`
`1811`		`- public function provideLanguagesWithoutAlpha2Equivalent()`
	`1811`	`+ public static function provideLanguagesWithoutAlpha2Equivalent()`
`1812`	`1812`	`{`
`1813`	`1813`	`return array_map(`
`1814`	`1814`	`function ($value) { return [$value]; },`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@`
`16`	`16`
`17`	`17`	`class LocaleTest extends TestCase`
`18`	`18`	`{`
`19`		`- public function provideGetFallbackTests()`
	`19`	`+ public static function provideGetFallbackTests()`
`20`	`20`	`{`
`21`	`21`	`$tests = [`
`22`	`22`	`['sl_Latn_IT', 'sl_Latn_IT_nedis'],`
Original file line number	Diff line number	Diff line change
`@@ -639,7 +639,7 @@ public function testGetCountryCodeAvailability(string $timezone)`
`639`	`639`	`}`
`640`	`640`	`}`
`641`	`641`
`642`		`- public function provideTimezones(): iterable`
	`642`	`+ public static function provideTimezones(): iterable`
`643`	`643`	`{`
`644`	`644`	`return array_map(function ($timezone) {`
`645`	`645`	`return [$timezone];`
`@@ -657,7 +657,7 @@ public function testForCountryCodeAvailability(string $country)`
`657`	`657`	`$this->addToAssertionCount(1);`
`658`	`658`	`}`
`659`	`659`
`660`		`- public function provideCountries(): iterable`
	`660`	`+ public static function provideCountries(): iterable`
`661`	`661`	`{`
`662`	`662`	`return array_map(function ($country) {`
`663`	`663`	`return [$country];`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@`
`19`	`19`	`*/`
`20`	`20`	`class IcuVersionTest extends TestCase`
`21`	`21`	`{`
`22`		`- public function normalizeProvider()`
	`22`	`+ public static function normalizeProvider()`
`23`	`23`	`{`
`24`	`24`	`return [`
`25`	`25`	`[null, '1', '10'],`
`@@ -49,7 +49,7 @@ public function testNormalize($precision, $version, $result)`
`49`	`49`	`$this->assertSame($result, IcuVersion::normalize($version, $precision));`
`50`	`50`	`}`
`51`	`51`
`52`		`- public function compareProvider()`
	`52`	`+ public static function compareProvider()`
`53`	`53`	`{`
`54`	`54`	`return [`
`55`	`55`	`[null, '1', '==', '1', true],`