Merge branch '4.4'

* 4.4:
  Fix compatibility with PHPUnit 8
  Disable phpunit typehint patch on 4.3 branch
  Fix deprecation on 4.3

Author: nicolas-grekas

Tests/Collator/Verification/CollatorTest.php

@@ -22,7 +22,7 @@
  */
 class CollatorTest extends AbstractCollatorTest
 {
-    protected function setUp()
+    protected function setUp(): void
     {
         IntlTestHelper::requireFullIntl($this, false);
 

Tests/Data/Bundle/Reader/BundleEntryReaderTest.php

@@ -62,7 +62,7 @@ class BundleEntryReaderTest extends TestCase
         'Foo' => 'Bar',
     ];
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->readerImpl = $this->getMockBuilder('Symfony\Component\Intl\Data\Bundle\Reader\BundleEntryReaderInterface')->getMock();
         $this->reader = new BundleEntryReader($this->readerImpl);

Tests/Data/Bundle/Reader/IntlBundleReaderTest.php

@@ -25,7 +25,7 @@ class IntlBundleReaderTest extends TestCase
      */
     private $reader;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->reader = new IntlBundleReader();
     }

Tests/Data/Bundle/Reader/JsonBundleReaderTest.php

@@ -24,7 +24,7 @@ class JsonBundleReaderTest extends TestCase
      */
     private $reader;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->reader = new JsonBundleReader();
     }

Tests/Data/Bundle/Reader/PhpBundleReaderTest.php

@@ -24,7 +24,7 @@ class PhpBundleReaderTest extends TestCase
      */
     private $reader;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->reader = new PhpBundleReader();
     }

Tests/Data/Bundle/Writer/JsonBundleWriterTest.php

@@ -32,7 +32,7 @@ class JsonBundleWriterTest extends TestCase
      */
     private $filesystem;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->writer = new JsonBundleWriter();
         $this->directory = sys_get_temp_dir().'/JsonBundleWriterTest/'.mt_rand(1000, 9999);
@@ -41,7 +41,7 @@ protected function setUp()
         $this->filesystem->mkdir($this->directory);
     }
 
-    protected function tearDown()
+    protected function tearDown(): void
     {
         $this->filesystem->remove($this->directory);
     }

Tests/Data/Bundle/Writer/PhpBundleWriterTest.php

@@ -32,7 +32,7 @@ class PhpBundleWriterTest extends TestCase
      */
     private $filesystem;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->writer = new PhpBundleWriter();
         $this->directory = sys_get_temp_dir().'/PhpBundleWriterTest/'.mt_rand(1000, 9999);
@@ -41,7 +41,7 @@ protected function setUp()
         $this->filesystem->mkdir($this->directory);
     }
 
-    protected function tearDown()
+    protected function tearDown(): void
     {
         $this->filesystem->remove($this->directory);
     }

Tests/Data/Bundle/Writer/TextBundleWriterTest.php

@@ -34,7 +34,7 @@ class TextBundleWriterTest extends TestCase
      */
     private $filesystem;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->writer = new TextBundleWriter();
         $this->directory = sys_get_temp_dir().'/TextBundleWriterTest/'.mt_rand(1000, 9999);
@@ -43,7 +43,7 @@ protected function setUp()
         $this->filesystem->mkdir($this->directory);
     }
 
-    protected function tearDown()
+    protected function tearDown(): void
     {
         $this->filesystem->remove($this->directory);
     }

Tests/Data/Util/LocaleScannerTest.php

@@ -32,7 +32,7 @@ class LocaleScannerTest extends TestCase
      */
     private $scanner;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->directory = sys_get_temp_dir().'/LocaleScannerTest/'.mt_rand(1000, 9999);
         $this->filesystem = new Filesystem();
@@ -62,7 +62,7 @@ protected function setUp()
         file_put_contents($this->directory.'/fr_child.txt', 'en_GB{%%Parent{"fr"}}');
     }
 
-    protected function tearDown()
+    protected function tearDown(): void
     {
         $this->filesystem->remove($this->directory);
     }

Tests/Data/Util/RingBufferTest.php

@@ -24,7 +24,7 @@ class RingBufferTest extends TestCase
      */
     private $buffer;
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->buffer = new RingBuffer(2);
     }