Merge branch '3.4'

* 3.4: (23 commits)
  [DI] Allow dumping inline services in Yaml
  fixed CS
  [2.8] Modify 2.8 upgrade doc - key option is deprecated.
  Fix lock failling test
  [Debug] Correctly detect methods not from the same vendor
  [HttpKernel] Deprecated commands auto-registration
  Fix minors in date caster
  [FrameworkBundle] Catch Fatal errors in commands registration
  [Debug] Detect internal and deprecated methods
  [Profiler] Make the validator toolbar item consistent with the form one
  [DebugBundle] Reword an outdated comment about var dumper wiring
  updated CHANGELOG
  [HttpFoundation] Remove length limit on ETag
  [DI] Fix some docblocks
  [DI] Fix some docblocks
  Fixed the exception page design in responsive mode
  [Console] Log exit codes as debug messages instead of errors
  Fixed UPGRADE-4.0 about Container::set
  Ignore memcached missing key error on dession destroy
  [FrameworkBundle] Allow micro kernel to subscribe events easily
  ...

Author: nicolas-grekas

Tests/Store/BlockingStoreTestTrait.php

@@ -35,36 +35,51 @@ abstract protected function getStore();
     public function testBlockingLocks()
     {
         // Amount a microsecond used to order async actions
-        $clockDelay = 200000;
+        $clockDelay = 50000;
 
         /** @var StoreInterface $store */
         $store = $this->getStore();
         $key = new Key(uniqid(__METHOD__, true));
+        $parentPID = posix_getpid();
 
-        if ($childPID1 = pcntl_fork()) {
-            // give time to fork to start
-            usleep(1 * $clockDelay);
+        // Block SIGHUP signal
+        pcntl_sigprocmask(SIG_BLOCK, array(SIGHUP));
+
+        if ($childPID = pcntl_fork()) {
+            // Wait the start of the child
+            pcntl_sigwaitinfo(array(SIGHUP), $info);
 
             try {
-                // This call should failed given the lock should already by acquired by the child #1
+                // This call should failed given the lock should already by acquired by the child
                 $store->save($key);
                 $this->fail('The store saves a locked key.');
             } catch (LockConflictedException $e) {
             }
 
+            // send the ready signal to the child
+            posix_kill($childPID, SIGHUP);
+
             // This call should be blocked by the child #1
             $store->waitAndSave($key);
             $this->assertTrue($store->exists($key));
             $store->delete($key);
 
             // Now, assert the child process worked well
-            pcntl_waitpid($childPID1, $status1);
+            pcntl_waitpid($childPID, $status1);
             $this->assertSame(0, pcntl_wexitstatus($status1), 'The child process couldn\'t lock the resource');
         } else {
+            // Block SIGHUP signal
+            pcntl_sigprocmask(SIG_BLOCK, array(SIGHUP));
             try {
                 $store->save($key);
-                // Wait 2 ClockDelay to let parent process to finish
-                usleep(2 * $clockDelay);
+                // send the ready signal to the parent
+                posix_kill($parentPID, SIGHUP);
+
+                // Wait for the parent to be ready
+                pcntl_sigwaitinfo(array(SIGHUP), $info);
+
+                // Wait ClockDelay to let parent assert to finish
+                usleep($clockDelay);
                 $store->delete($key);
                 exit(0);
             } catch (\Exception $e) {