Merge branch '3.4'

* 3.4:
  [Yaml] Recommend using quotes instead of PARSE_KEYS_AS_STRINGS
  [DependencyInjection] Deprecate autowiring service auto-registration
  Removed useless argument $definition
  [DI] Generate shorter method names for class-based ids
  Fix comment
  [Config] Fix checking class existence freshness
  bumped Symfony version to 3.3.7
  updated VERSION for 3.3.6
  updated CHANGELOG for 3.3.6
  Autoconfigure instances of ArgumentValueResolverInterface
  Deprecate Filesystem/LockHandler
  improve sql explain table display
  Bump minimal PHP version to ^5.5.9|>=7.0.8

Author: nicolas-grekas

Store/SemaphoreStore.php

@@ -24,9 +24,24 @@
  */
 class SemaphoreStore implements StoreInterface
 {
-    public static function isSupported()
+    /**
+     * Returns whether or not the store is supported.
+     *
+     * @param bool|null $blocking When not null, checked again the blocking mode.
+     *
+     * @return bool
+     */
+    public static function isSupported($blocking = null)
     {
-        return extension_loaded('sysvsem');
+        if (!extension_loaded('sysvsem')) {
+            return false;
+        }
+
+        if ($blocking === false && \PHP_VERSION_ID < 50601) {
+            return false;
+        }
+
+        return true;
     }
 
     public function __construct()

Tests/Store/BlockingStoreTestTrait.php

@@ -35,15 +35,15 @@ abstract protected function getStore();
     public function testBlockingLocks()
     {
         // Amount a microsecond used to order async actions
-        $clockDelay = 50000;
+        $clockDelay = 200000;
 
         /** @var StoreInterface $store */
         $store = $this->getStore();
         $key = new Key(uniqid(__METHOD__, true));
 
         if ($childPID1 = pcntl_fork()) {
             // give time to fork to start
-            usleep(2 * $clockDelay);
+            usleep(1 * $clockDelay);
 
             try {
                 // This call should failed given the lock should already by acquired by the child #1
@@ -63,8 +63,8 @@ public function testBlockingLocks()
         } else {
             try {
                 $store->save($key);
-                // Wait 3 ClockDelay to let parent process to finish
-                usleep(3 * $clockDelay);
+                // Wait 2 ClockDelay to let parent process to finish
+                usleep(2 * $clockDelay);
                 $store->delete($key);
                 exit(0);
             } catch (\Exception $e) {