[Mailer] Stream timeout not detected due to checking only string result of function fgets

Sezil · fabpot · commit 554b8c0dc2db · 2022-11-04T07:30:35.000+01:00
diff --git a/Transport/Smtp/Stream/AbstractStream.php b/Transport/Smtp/Stream/AbstractStream.php
@@ -75,7 +75,7 @@ public function readLine(): string
         }
 
         $line = fgets($this->out);
-        if ('' === $line) {
+        if ('' === $line || false === $line) {
             $metas = stream_get_meta_data($this->out);
             if ($metas['timed_out']) {
                 throw new TransportException(sprintf('Connection to "%s" timed out.', $this->getReadConnectionDescription()));

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ public function readLine(): string`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`$line = fgets($this->out);`
`78`		`- if ('' === $line) {`
	`78`	`+ if ('' === $line \|\| false === $line) {`
`79`	`79`	`$metas = stream_get_meta_data($this->out);`
`80`	`80`	`if ($metas['timed_out']) {`
`81`	`81`	`throw new TransportException(sprintf('Connection to "%s" timed out.', $this->getReadConnectionDescription()));`