Merge branch '4.4'

* 4.4:
  [HttpClient] Fix a bug preventing Server Pushes to be handled properly
  [HttpClient] fix support for 103 Early Hints and other informational status codes
  fix typo
  [DI] fix failure
  [Validator] Add ConstraintValidator::formatValue() tests
  [HttpClient] improve handling of HTTP/2 PUSH
  Fix #33427
  lint all templates from configured Twig paths if no argument was provided
  Nullable message id?
  [Validator] Only handle numeric values in DivisibleBy
  [Validator] Sync string to date behavior and throw a better exception
  Check phpunit configuration for listeners
  registering basic exception handler for late failures
  [DI] fix support for "!tagged_locator foo"
  [Mailer] Add a more precise exception
  [ErrorHandler][Bridge/PhpUnit] display deprecations for not-autoloaded classes

Author: nicolas-grekas

Tests/Transport/TransportsTest.php

@@ -12,6 +12,7 @@
 namespace Symfony\Component\Mailer\Tests\Transport;
 
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Mailer\Exception\InvalidArgumentException;
 use Symfony\Component\Mailer\Transport\TransportInterface;
 use Symfony\Component\Mailer\Transport\Transports;
 use Symfony\Component\Mime\Header\Headers;
@@ -48,4 +49,19 @@ public function testOverrideTransport()
         $email = new Message($headers, new TextPart('...'));
         $transport->send($email);
     }
+
+    public function testTransportDoesNotExist()
+    {
+        $transport = new Transports([
+            'foo' => $this->createMock(TransportInterface::class),
+            'bar' => $this->createMock(TransportInterface::class),
+        ]);
+
+        $headers = (new Headers())->addTextHeader('X-Transport', 'foobar');
+        $email = new Message($headers, new TextPart('...'));
+
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('The "foobar" transport does not exist (available transports: "foo", "bar").');
+        $transport->send($email);
+    }
 }

Transport/Transports.php

@@ -56,7 +56,7 @@ public function send(RawMessage $message, SmtpEnvelope $envelope = null): ?SentM
         $headers->remove('X-Transport');
 
         if (!isset($this->transports[$transport])) {
-            throw new InvalidArgumentException(sprintf('The "%s" transport does not exist.', $transport));
+            throw new InvalidArgumentException(sprintf('The "%s" transport does not exist (available transports: "%s").', $transport, implode('", "', array_keys($this->transports))));
         }
 
         return $this->transports[$transport]->send($message, $envelope);

Transports.php

@@ -56,7 +56,7 @@ public function send(RawMessage $message, SmtpEnvelope $envelope = null): ?SentM
         $headers->remove('X-Transport');
 
         if (!isset($this->transports[$transport])) {
-            throw new InvalidArgumentException(sprintf('The "%s" transport does not exist.', $transport));
+            throw new InvalidArgumentException(sprintf('The "%s" transport does not exist (available transports: "%s").', $transport, implode('", "', array_keys($this->transports))));
         }
 
         return $this->transports[$transport]->send($message, $envelope);

TransportsTest.php

@@ -12,6 +12,7 @@
 namespace Symfony\Component\Mailer\Tests\Transport;
 
 use PHPUnit\Framework\TestCase;
+use Symfony\Component\Mailer\Exception\InvalidArgumentException;
 use Symfony\Component\Mailer\Transport\TransportInterface;
 use Symfony\Component\Mailer\Transport\Transports;
 use Symfony\Component\Mime\Header\Headers;
@@ -48,4 +49,19 @@ public function testOverrideTransport()
         $email = new Message($headers, new TextPart('...'));
         $transport->send($email);
     }
+
+    public function testTransportDoesNotExist()
+    {
+        $transport = new Transports([
+            'foo' => $this->createMock(TransportInterface::class),
+            'bar' => $this->createMock(TransportInterface::class),
+        ]);
+
+        $headers = (new Headers())->addTextHeader('X-Transport', 'foobar');
+        $email = new Message($headers, new TextPart('...'));
+
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('The "foobar" transport does not exist (available transports: "foo", "bar").');
+        $transport->send($email);
+    }
 }