Resolve code review comments from stof and oska

Also fix one mysteriously broken unit test.

Author: arnt

CHANGELOG.md

@@ -5,7 +5,7 @@ CHANGELOG
 ---
 
  * Make `TransportFactoryTestCase` compatible with PHPUnit 10+
- * Support unicode email addresses such as "dømi@dømi.fo", no client changes needed
+ * Support unicode email addresses such as "dømi@dømi.fo"
 
 7.1
 ---

Envelope.php

@@ -83,7 +83,6 @@ public function getRecipients(): array
     }
 
     /**
-
       * Returns true if any address' localpart contains at least one
       * non-ASCII character, and false if all addresses have all-ASCII
       * localparts.
@@ -97,8 +96,6 @@ public function getRecipients(): array
       * then it is possible to to send the message using IDN encoding
       * instead of SMTPUTF8. The most common software will display the
       * message as intended.
-      *
-      * @return bool
       */
     public function anyAddressHasUnicodeLocalpart(): bool
     {

Transport/Smtp/EsmtpTransport.php

@@ -195,7 +195,7 @@ private function parseCapabilities(string $ehloResponse): array
         return $capabilities;
     }
 
-    protected function serverSupportsSmtputf8(): bool
+    protected function serverSupportsSmtpUtf8(): bool
     {
         return \array_key_exists('SMTPUTF8', $this->capabilities);
     }

Transport/Smtp/SmtpTransport.php

@@ -245,7 +245,7 @@ protected function doSend(SentMessage $message): void
         }
     }
 
-    protected function serverSupportsSmtputf8(): bool
+    protected function serverSupportsSmtpUtf8(): bool
     {
         return false;
     }
@@ -257,7 +257,7 @@ private function doHeloCommand(): void
 
     private function doMailFromCommand(string $address, bool $smtputf8): void
     {
-        if($smtputf8 && !$this->serverSupportsSmtputf8()) {
+        if($smtputf8 && !$this->serverSupportsSmtpUtf8()) {
             throw new InvalidArgumentException('Invalid addresses: non-ASCII characters not supported in local-part of email.');
         }
         $this->executeCommand(sprintf("MAIL FROM:<%s>%s\r\n", $address, ($smtputf8 ? " SMTPUTF8" : "")), [250]);