Fixing bug when a yaml key with no value ends a file

Author: weaverryan

src/Util/YamlSourceManipulator.php

@@ -217,7 +217,7 @@ private function updateData(array $newData)
             }
 
             // 3b) value DID change
-            $this->log('updating value');
+            $this->log(sprintf('updating value to {%s}', is_array($newVal) ? '<array>' : $newVal));
             $this->changeValueInYaml($newVal);
         }
 
@@ -765,6 +765,12 @@ private function findEndPositionOfValue($value, $offset = null)
 
             $offset = null === $offset ? $this->currentPosition : $offset;
 
+            // a value like "foo:" can simply end a file
+            // this means the value is null
+            if ($offset === strlen($this->contents)) {
+                return $offset;
+            }
+
             preg_match(sprintf('#%s#', $pattern), $this->contents, $matches, PREG_OFFSET_CAPTURE, $offset);
             if (empty($matches)) {
                 throw new YamlManipulationFailedException(sprintf('Cannot find the original value "%s"', $value));

tests/Util/yaml_fixtures/last_value_is_blank.test

@@ -0,0 +1,7 @@
+security:
+    access_control:
+===
+$data['security']['access_control'] = 'foo';
+===
+security:
+    access_control: foo