minor #497 [sfhackday2019] Fixing tests (sadikoff)

This PR was squashed before being merged into the 1.0-dev branch (closes #497).

Discussion
----------

[sfhackday2019] Fixing tests

Improve symlinking phpunit-bridge inside testing flex project.

Commits
-------

4712a5d move clearing cache before premake
4b2a876 configure dev and stable-dev works with php7.2
39d5f4b remove wrong use statement
93e0e7e fixing tests

Author: weaverryan

.travis.yml

@@ -18,9 +18,9 @@ matrix:
     fast_finish: true
     include:
         - php: 7.3
-        - php: 7.1
+        - php: 7.2
           env: MAKER_TEST_VERSION=stable-dev
-        - php: 7.1
+        - php: 7.2
           env: MAKER_TEST_VERSION=dev
 
 before_install:

src/Test/MakerTestDetails.php

@@ -47,9 +47,6 @@ final class MakerTestDetails
     private $guardAuthenticators = [];
 
     /**
-     * @param MakerInterface $maker
-     * @param array          $inputs
-     *
      * @return static
      */
     public static function createTest(MakerInterface $maker, array $inputs)

src/Test/MakerTestEnvironment.php

@@ -199,11 +199,11 @@ private function preMake()
 
     public function runMaker()
     {
-        $this->preMake();
-
         // Lets remove cache
         $this->fs->remove($this->path.'/var/cache');
 
+        $this->preMake();
+
         // We don't need ansi coloring in tests!
         $testProcess = MakerTestProcess::create(
             sprintf('php bin/console %s %s --no-ansi', $this->testDetails->getMaker()::getCommandName(), $this->testDetails->getArgumentsString()),
@@ -350,12 +350,11 @@ private function buildFlexSkeleton()
         // fetch a few packages needed for testing
         MakerTestProcess::create('composer require phpunit browser-kit symfony/css-selector --prefer-dist --no-progress --no-suggest', $this->flexPath)
                         ->run();
-        $this->fs->remove($this->flexPath.'/vendor/symfony/phpunit-bridge');
 
         if ('\\' !== \DIRECTORY_SEPARATOR) {
-            $this->fs->symlink('../../../../../../vendor/symfony/phpunit-bridge', './vendor/symfony/phpunit-bridge');
-        } else {
-            $this->fs->mirror(\dirname(__DIR__, 2).'/vendor/symfony/phpunit-bridge', $this->flexPath.'/vendor/symfony/phpunit-bridge');
+            $this->fs->remove($this->flexPath.'/vendor/symfony/phpunit-bridge');
+
+            $this->fs->symlink($rootPath.'/vendor/symfony/phpunit-bridge', $this->flexPath.'/vendor/symfony/phpunit-bridge');
         }
 
         // temporarily ignoring indirect deprecations - see #237