fixed deprecated ReflectionType::__toString()

jrushlow · jrushlow · commit 3a0a2acf81b4 · 2021-03-02T02:57:45.000-05:00
diff --git a/src/Maker/MakeAuthenticator.php b/src/Maker/MakeAuthenticator.php
@@ -403,11 +403,12 @@ public function configureDependencies(DependencyBuilder $dependencies, InputInte
     private function providerKeyTypeHint(): string
     {
         $reflectionMethod = new \ReflectionMethod(AbstractFormLoginAuthenticator::class, 'onAuthenticationSuccess');
-        $typeHint = (string) $reflectionMethod->getParameters()[2]->getType();
-        if ($typeHint) {
-            $typeHint .= ' ';
+        $type = $reflectionMethod->getParameters()[2]->getType();
+
+        if (!$type instanceof \ReflectionNamedType) {
+            return '';
         }
 
-        return $typeHint;
+        return sprintf('%s ', $type->getName());
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -403,11 +403,12 @@ public function configureDependencies(DependencyBuilder $dependencies, InputInte`
`403`	`403`	`private function providerKeyTypeHint(): string`
`404`	`404`	`{`
`405`	`405`	`$reflectionMethod = new \ReflectionMethod(AbstractFormLoginAuthenticator::class, 'onAuthenticationSuccess');`
`406`		`- $typeHint = (string) $reflectionMethod->getParameters()[2]->getType();`
`407`		`- if ($typeHint) {`
`408`		`- $typeHint .= ' ';`
	`406`	`+ $type = $reflectionMethod->getParameters()[2]->getType();`
	`407`	`+`
	`408`	`+ if (!$type instanceof \ReflectionNamedType) {`
	`409`	`+ return '';`
`409`	`410`	`}`
`410`	`411`
`411`		`- return $typeHint;`
	`412`	`+ return sprintf('%s ', $type->getName());`
`412`	`413`	`}`
`413`	`414`	`}`